[OE-core] [PATCH] support CONFIG_MODULE_COMPRESS=y

richard.purdie at linuxfoundation.org richard.purdie at linuxfoundation.org
Wed Apr 3 17:10:07 UTC 2019


On Wed, 2019-04-03 at 19:05 +0200, Jens Rehsack wrote:
> 
> 
> > Am 03.04.2019 um 15:58 schrieb Richard Purdie <
> > richard.purdie at linuxfoundation.org>:
> > 
> > On Wed, 2019-04-03 at 15:18 +0200, Jens Rehsack wrote:
> > > In case, kernel config enables compressed modules, support of
> > > splitting via split_kernel_module_packages won't find any module.
> > > So, first expand module pattern regex to recognize compressed
> > > modules and then objcopy on temporary extacted to extract module
> > > information.
> > > 
> > > Signed-off-by: Jens Rehsack <sno at netbsd.org>
> > > ---
> > > meta/classes/kernel-module-split.bbclass | 36 +++++++++++++++++
> > > -----
> > > --
> > > 1 file changed, 26 insertions(+), 10 deletions(-)
> > 
> > There is a lot of whitespace noise in this, could you clean that up
> > and
> > resend please?
> 
> It's because of <tab>s were replaced with spaces - which is
> reasonable when python code is mixed in.
> Sure that you want keep the tab's?

Rightly or wrongly, the style convention for OE-Core is tabs in shell,
spaces in python (I'd prefer not to open that can of worms again right
now).

Whitespace changes need to be in a separate patch to code changes
regardless.

Cheers,

Richard



More information about the Openembedded-core mailing list