[OE-core] [PATCH] support CONFIG_MODULE_COMPRESS=y
Jens Rehsack
sno at netbsd.org
Thu Apr 4 09:19:48 UTC 2019
> Am 03.04.2019 um 19:10 schrieb richard.purdie at linuxfoundation.org:
>
> On Wed, 2019-04-03 at 19:05 +0200, Jens Rehsack wrote:
>>
>>
>>> Am 03.04.2019 um 15:58 schrieb Richard Purdie <
>>> richard.purdie at linuxfoundation.org>:
>>>
>>> On Wed, 2019-04-03 at 15:18 +0200, Jens Rehsack wrote:
>>>> In case, kernel config enables compressed modules, support of
>>>> splitting via split_kernel_module_packages won't find any module.
>>>> So, first expand module pattern regex to recognize compressed
>>>> modules and then objcopy on temporary extacted to extract module
>>>> information.
>>>>
>>>> Signed-off-by: Jens Rehsack <sno at netbsd.org>
>>>> ---
>>>> meta/classes/kernel-module-split.bbclass | 36 +++++++++++++++++
>>>> -----
>>>> --
>>>> 1 file changed, 26 insertions(+), 10 deletions(-)
>>>
>>> There is a lot of whitespace noise in this, could you clean that up
>>> and
>>> resend please?
>>
>> It's because of <tab>s were replaced with spaces - which is
>> reasonable when python code is mixed in.
>> Sure that you want keep the tab's?
>
> Rightly or wrongly, the style convention for OE-Core is tabs in shell,
> spaces in python (I'd prefer not to open that can of worms again right
> now).
That wasn't the intension - I just wanted to be sure.
> Whitespace changes need to be in a separate patch to code changes
> regardless.
Understood.
Cheers
--
Jens Rehsack - rehsack at gmail.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Message signed with OpenPGP
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20190404/29a55f45/attachment-0001.sig>
More information about the Openembedded-core
mailing list