[OE-core] [PATCH] virglrenderer: remove link option -Bsymbolic

[Kang Kai]

On 2019/4/9 上午12:36, Khem Raj wrote:
> On Sun, Apr 7, 2019 at 6:59 PM Kang Kai <Kai.Kang at windriver.com> wrote:
>> On 2019/4/4 下午3:52, kai.kang at windriver.com wrote:
>>> From: Kai Kang <kai.kang at windriver.com>
>>>
>>> When gcc compile options '-O2 -fvisibility=default' are applied, it
>>> fails to compile virglrenderer for x86:
>>>
>>> | ld: gallium/auxiliary/.libs/libgallium.a(u_cpu_detect.o): relocation
>>>     R_386_GOTOFF against undefined symbol `util_cpu_caps' can not be used
>>>     when making a shared object
>>> | ld: final link failed: bad value
>>> | collect2: error: ld returned 1 exit status
>>>
>>> Remove link option '-Bsymbolic' to fix the failure.
>>
>> Any comments on this patch? Thank.
>>
>> Kai
>>
>>
>>> Signed-off-by: Kai Kang <kai.kang at windriver.com>
>>> ---
>>>    .../0001-Remove-link-option-Bsymbolic.patch   | 34 +++++++++++++++++++
>>>    .../virglrenderer/virglrenderer_0.7.0.bb      |  1 +
>>>    2 files changed, 35 insertions(+)
>>>    create mode 100644 meta/recipes-graphics/virglrenderer/virglrenderer/0001-Remove-link-option-Bsymbolic.patch
>>>
>>> diff --git a/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Remove-link-option-Bsymbolic.patch b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Remove-link-option-Bsymbolic.patch
>>> new file mode 100644
>>> index 0000000000..faefa16aae
>>> --- /dev/null
>>> +++ b/meta/recipes-graphics/virglrenderer/virglrenderer/0001-Remove-link-option-Bsymbolic.patch
>>> @@ -0,0 +1,34 @@
>>> +When gcc compile options '-O2 -fvisibility=default' are applied, it fails to
>>> +compile virglrenderer for x86:
>>> +
>>> +| ld: gallium/auxiliary/.libs/libgallium.a(u_cpu_detect.o): relocation
>>> +  R_386_GOTOFF against undefined symbol `util_cpu_caps' can not be used
>>> +  when making a shared object
>>> +| ld: final link failed: bad value
>>> +| collect2: error: ld returned 1 exit status
>>> +
>>> +Remove link option '-Bsymbolic' to fix the failure.
>>> +
> In spite of removing the option can we try replacing it with
> -Bsymbolic-functions


Thanks. I'll try it.

Regards,
Kai


>
>>> +Upstream-Status: Submitted [https://gitlab.freedesktop.org/virgl/virglrenderer/merge_requests/213]
>>> +
>>> +Signed-off-by: Kai Kang <kai.kang at windriver.com>
>>> +---
>>> + src/Makefile.am | 2 +-
>>> + 1 file changed, 1 insertion(+), 1 deletion(-)
>>> +
>>> +diff --git a/src/Makefile.am b/src/Makefile.am
>>> +index 9b668c8..7a421b8 100644
>>> +--- a/src/Makefile.am
>>> ++++ b/src/Makefile.am
>>> +@@ -48,7 +49,7 @@ endif
>>> + lib_LTLIBRARIES = libvirglrenderer.la
>>> + noinst_LTLIBRARIES = libvrend.la
>>> +
>>> +-GM_LDFLAGS = -Wl,-Bsymbolic -version-number 0:2 -no-undefined
>>> ++GM_LDFLAGS = -version-number 0:2 -no-undefined
>>> +
>>> + libvirglrenderer_la_SOURCES = virglrenderer.c
>>> + libvirglrenderer_ladir = $(libdir)
>>> +--
>>> +2.20.1
>>> +
>>> diff --git a/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb b/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb
>>> index 225a0b8b0c..afc709bc48 100644
>>> --- a/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb
>>> +++ b/meta/recipes-graphics/virglrenderer/virglrenderer_0.7.0.bb
>>> @@ -9,6 +9,7 @@ SRCREV = "402c228861c9893f64cffbbcb4cb23044b8c721c"
>>>    SRC_URI = "git://anongit.freedesktop.org/virglrenderer \
>>>               file://0001-vtest-add-missing-includes.patch \
>>>               file://0001-Makefile.am-explicitly-link-with-libdrm.patch \
>>> +           file://0001-Remove-link-option-Bsymbolic.patch \
>>>               "
>>>
>>>    S = "${WORKDIR}/git"
>>
>> --
>> Kai Kang
>>

-- 
Kai Kang