[OE-core] [meta-oe,v2] kernel-fitimage: introduce FIT_HASH_ALG

richard.purdie at linuxfoundation.org richard.purdie at linuxfoundation.org
Wed Jun 19 14:51:22 UTC 2019


On Wed, 2019-06-19 at 10:14 +0100, Luca Boccassi wrote:
> On Wed, 2019-06-19 at 10:06 +0100, Alex Kiernan wrote:
> > On Wed, Jun 19, 2019 at 9:48 AM Luca Boccassi <
> > luca.boccassi at gmail.com
> > > 
> > > Thanks Richard - in case it helps, we've been using this patch
> > > for a few months at $work (on top of sumo) and it seems to work
> > > fine.
> > > 
> > 
> > I expect that's true for everyone touching stuff in this class - it
> > works fine for them... the problem is everyone else, since it's
> > terribly fragile and has no tests.
> > 
> > I'd not be at all surprised if changing the default from sha1 to
> > sha256 doesn't break someone.
> 
> Keeping the default to sha1 would be fine by me, it's the ability to
> configure it that is useful.

Its merged and it probably makes sense to change the default, I just
continue to worry about how we can test this class and make sure the
commonly used workflows continue to work...

Cheers,

Richard



More information about the Openembedded-core mailing list