[OE-core] [PATCH] meta: handle UBOOT_CONFIG in image.bbclass

Richard Purdie richard.purdie at linuxfoundation.org
Thu May 16 08:23:21 UTC 2019


On Wed, 2019-05-15 at 21:22 +0200, liu.ming50 at gmail.com wrote:
> From: Ming Liu <liu.ming50 at gmail.com>
> 
> The code dealing with IMAGE_FSTYPES in uboot-config.bbclass would not
> take any effect since it's in a uboot particular class, but it's not
> being inherited by any image recipes.
> 
> Move the IMAGE_FSTYPES handling part to image.bbclass would make it
> really work.
> 
> Also drop some trivial debug code.
> 
> Signed-off-by: Ming Liu <liu.ming50 at gmail.com>
> ---
>  meta/classes/image.bbclass        | 12 ++++++++++++
>  meta/classes/uboot-config.bbclass | 17 ++++-------------
>  meta/conf/documentation.conf      |  2 +-
>  3 files changed, 17 insertions(+), 14 deletions(-)

This doesn't make sense, if we want to set IMAGE_FSTYPES, lets just set
that.

I'd imagine the code is designed so you'd inherit uboot-config in the
machine and this therefore could be made to work as is.

Moving the code to image.bbclass is the wrong thing to do though and
I'd question whether we want UBOOT_CONFIG doing this at all...

Cheers,

Richard



More information about the Openembedded-core mailing list