[OE-core] [PATCH] meta: handle UBOOT_CONFIG in image.bbclass

[Ming Liu]

Hi, Richard:

> I'd imagine the code is designed so you'd inherit uboot-config in the
machine and this therefore could be made to work as is.

Yes, that probably is how the author intended it to be used, but
unfortunately, that's not how it's being used in BSP layers, that fact is,
in most BSP meta layers, they do not put it into INHERIT, only u-boot
recipes are inheriting uboot-config.

I am on board there is no need to set IMAGE_FSTYPES in
uboot-config.bbclass, maybe we should drop it from UBOOT_CONFIG and it
would be like: 'UBOOT_CONFIG = "config,,binary"', there will be a empty
item in the middle, so the BSP meta layers would work as usual.

Will send a V2 if you agree with this.

//Ming Liu

Richard Purdie <richard.purdie at linuxfoundation.org> 於 2019年5月16日 週四
上午10:23寫道：

> On Wed, 2019-05-15 at 21:22 +0200, liu.ming50 at gmail.com wrote:
> > From: Ming Liu <liu.ming50 at gmail.com>
> >
> > The code dealing with IMAGE_FSTYPES in uboot-config.bbclass would not
> > take any effect since it's in a uboot particular class, but it's not
> > being inherited by any image recipes.
> >
> > Move the IMAGE_FSTYPES handling part to image.bbclass would make it
> > really work.
> >
> > Also drop some trivial debug code.
> >
> > Signed-off-by: Ming Liu <liu.ming50 at gmail.com>
> > ---
> >  meta/classes/image.bbclass        | 12 ++++++++++++
> >  meta/classes/uboot-config.bbclass | 17 ++++-------------
> >  meta/conf/documentation.conf      |  2 +-
> >  3 files changed, 17 insertions(+), 14 deletions(-)
>
> This doesn't make sense, if we want to set IMAGE_FSTYPES, lets just set
> that.
>
> I'd imagine the code is designed so you'd inherit uboot-config in the
> machine and this therefore could be made to work as is.
>
> Moving the code to image.bbclass is the wrong thing to do though and
> I'd question whether we want UBOOT_CONFIG doing this at all...
>
> Cheers,
>
> Richard
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openembedded.org/pipermail/openembedded-core/attachments/20190516/8b159d3a/attachment-0001.html>