[OE-core] [OE-Core][PATCH] diffutils: Add valgrind to support ptest

Randy MacLeod randy.macleod at windriver.com
Thu Sep 5 16:41:56 UTC 2019


On 9/5/19 11:38 AM, Peiran Hong wrote:
> From: Peiran Hong <Peiran.Hong at windriver.com>
Drop this line please.
Was there some documentation that suggested it was required?

Otherwise looks fine so please send a v2.

../Randy
> 
> The test "strip-trailing-cr" for diffutils package is skipped since it requires
> valgrind to run. This commit adds valgrind to the run-time dependency of
> the recipe for diffutils.
> 
> Signed-off-by: Peiran Hong <Peiran.Hong at windriver.com>
> ---
>   meta/recipes-extended/diffutils/diffutils_3.7.bb | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-extended/diffutils/diffutils_3.7.bb b/meta/recipes-extended/diffutils/diffutils_3.7.bb
> index 7daeee3513..2d763633b6 100644
> --- a/meta/recipes-extended/diffutils/diffutils_3.7.bb
> +++ b/meta/recipes-extended/diffutils/diffutils_3.7.bb
> @@ -17,7 +17,9 @@ acpaths = "-I ./m4"
>   
>   inherit ptest
>   
> -RDEPENDS_${PN}-ptest += "make"
> +# Include valgrind since the test "strip-trailing-cr" requires it to run, although
> +# valgrind is a heavy package for diffutils
> +RDEPENDS_${PN}-ptest += "make valgrind"
>   
>   do_install_ptest() {
>   	t=${D}${PTEST_PATH}
> 


-- 
# Randy MacLeod
# Wind River Linux


More information about the Openembedded-core mailing list