[OE-core] [OE-Core][PATCH] diffutils: Add valgrind to support ptest

[Richard Purdie]

On Thu, 2019-09-05 at 11:38 -0400, Peiran Hong wrote:
> From: Peiran Hong <Peiran.Hong at windriver.com>
> 
> The test "strip-trailing-cr" for diffutils package is skipped since
> it requires
> valgrind to run. This commit adds valgrind to the run-time dependency
> of
> the recipe for diffutils.
> 
> Signed-off-by: Peiran Hong <Peiran.Hong at windriver.com>
> ---
>  meta/recipes-extended/diffutils/diffutils_3.7.bb | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/meta/recipes-extended/diffutils/diffutils_3.7.bb
> b/meta/recipes-extended/diffutils/diffutils_3.7.bb
> index 7daeee3513..2d763633b6 100644
> --- a/meta/recipes-extended/diffutils/diffutils_3.7.bb
> +++ b/meta/recipes-extended/diffutils/diffutils_3.7.bb
> @@ -17,7 +17,9 @@ acpaths = "-I ./m4"
>  
>  inherit ptest
>  
> -RDEPENDS_${PN}-ptest += "make"
> +# Include valgrind since the test "strip-trailing-cr" requires it to
> run, although
> +# valgrind is a heavy package for diffutils
> +RDEPENDS_${PN}-ptest += "make valgrind"

This effectively means "bitbake diffutils" now requires valgrind to
build before it. I'm not sure its worth doing that for a single test?

Cheers,

Richard