[oe] postinst jobs and "exit 1"

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Richard Purdie schreef:
> On Thu, 2006-09-14 at 15:02 +0200, Martin Dietze wrote:
>>  lots of packages start their postinst jobs like this:
>>
>> | test -z "$D" || exit 1
>>
>> When creating firmware images using recent OE recipes (nylon
>> distro and mtx-2 hardware), this seems to cause problems,
>> either bitbake complains about "exit 1" in the log file when
>> doing the rootfs or lots of postinst jobs are not run after
>> installing the image. 
>>
>> Is the above test deprecated and should be replaced by
>> something not exit'ing at all? If yes, who is going to adapt
>> all the existing packages still doing this?
> 
> Packages do this if the postinst should run on the device and should not
> be during do_rootfs. If the postinst can be safely run during postinst,
> you wouldn't have a line like this.

isn't the 'if x$D == x' test preferred over the above test?[1]

regards,

Koen


[1] I really don't know

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)

iD8DBQFFCWIiMkyGM64RGpERAq1mAJ0TI7T1qOlBi9tb7A8oPc6dmLwGdACffKeU
cPxJYtR3N37AylFrzjSniUA=
=N/7O
-----END PGP SIGNATURE-----