[oe] pfalcon: revert r5dc6982e... vfat nls modules are not for task-base-kernel26

Rod Whitby rod at whitby.id.au
Tue Dec 18 00:24:06 UTC 2007


<CIA-34> pfalcon org.oe.dev * r5dc6982e... / (1
packages/tasks/task-base.bb):
<CIA-34> task-base: Add NLS modules for VFAT support.
<CIA-34> * Add to task-base-kernel26, as vfat is pretty basic feature.
<CIA-34> Worth refactoring to vfat feature still, I guess.

You guessed right.

kernel26 is not a kitchen sink where you can just add vfat-related nls
modules that are not strictly required for booting a 2.6 kernel.

Your addition has just *bloated* the rootfs for *every* 2.6 machine,
including those that have no possible way of ever mounting an external
memory stick at all, let alone a vfat-formatted one.

vfat is *not* a basic feature that should be enabled for all 2.6 kernel
machines.  If you want vfat nls modules, then create a vfat feature
(just like there is an ext2 feature).  Do not pollute the basic kernel26
feature with this stuff.

And the comment about "# If you don't need VFAT support - don't enable
them in defconfig." is not applicable, because there are machines that
want vfat-related nls modules available in the feed as a downloadable
package, but not in the initial rootfs.  Therefore they need to be in
the defconfig, but certainly should not be in task-base-kernel26.

I expect you to revert this change and do it properly, or not do it at all.

-- Rod




More information about the Openembedded-devel mailing list