[oe] mtn disapprove d7758e2637918ff4035244d64fb7227f6cf833ad, was Re: [oe-commits] org.oe.dev phoneserver: Add patch for FIC GTA01 support.

[Koen Kooi]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Florian Boor schreef:
> Hi,
> 
> 
> Koen Kooi schrieb:
>> florian commit schreef:
>>
>>> +PACKAGE_ARCH = "${MACHINE}"
>> This has to stop, OE is usable without setting MACHINE. The correct form is either
>>
>> PACKAGE_ARCH = "${MACHINE_ARCH}"
> 
> thanks for the hint.
> 
> For these trivial changes that do not break much I would really like to see if
> people do not disapprove    the whole patch but just go ahead and fix the
> problem - that is way more productive.

You are right that it's more productive to fix small errors than to disapprove, but:
I did that the first few times with PACKAGE_ARCH = "${MACHINE}", and people still keep
adding it, so now I'm doing dissaprove + mail to oe-devel to raise awareness.
Fixing errors afterwards is only productive if people learn from it and stop making the
same error again, which wasn't the case here.

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFGpyYvMkyGM64RGpERAgw7AJ9tKipgz+vizFvVePbq1/HBWJs+LwCgsu6R
DN165yNkXzUHhUvuzoCmJEE=
=dO8M
-----END PGP SIGNATURE-----