[oe] Please review john_lee/openmoko-toolchain

John Lee john_lee at openmoko.org
Mon Dec 22 09:29:36 UTC 2008


Hi,

This branch contains just 4 extra commits but these are highly
controversial.


    meta-toolchain.bb: introduce POPULATE_SDK_EXTRA_TASK
    
    In case some more modifications are required before the toolchain is
    packaged up, introduce this variable to do extra tasks right before
    packaging.


    meta-toolchain-openmoko.bb: add feed to toolchain
    
    By modifying the opkg config files in the toolchain, the toolchain can
    expend itself by installing packages from the repository.


We need to do some modifications to the contents of toolchain before
the packaging complete, so we use this variable as a hook.  The
modification is to create an opkg config file so the toolchain knows
where to get new packages.  A better way might be to install
distro-feed-configs, but that includes several opkg config files while
alias 'opkg-target' uses just one: opkg.conf.


    libtool-sdk_1.5.10.bb, meta-toolchain.bb, task-sdk-host.bb: introduce
    sysroot libtool-sdk.
    
    Add libtool-sdk to help the meta toolchain using the .la files.  Patch
    add_sysroot_function.patch is applied to teach libtool about
    LIBTOOL_SYSROOT_PATH .
    
    task-sdk-host.bb is updated along with its consumers to include
    libtool-sdk, and meta-toolchain.bb is updated to include this
    environment variable.


After some packages is installed by user to extend the toolchain, one
will find out that the .la files in the -dev packages often contain
incorrect paths.  In order to solve that, LIBTOOL_SYSROOT_PATH is
introduced, and it works just like PKG_CONFIG_SYSROOT_DIR.

This patch is posted to upstream already:

http://lists.gnu.org/archive/html/libtool-patches/2008-12/msg00000.html


    autotools.bbclass: adding do_install_append() to autotools.bbclass
    
    This function is used to correct .la files.  Many bb files use their
    own do_install so just adding this into the original
    autoclass_do_install won't work.  This ensures the .la files contain
    correct path.


The last commit along is not enough to fix the .la files.  This
enforces do_install to check the .la files and fix them.


Comments?  Flames?


Regards,
John




More information about the Openembedded-devel mailing list