[oe] mtn disapprove

Koen Kooi k.kooi at student.utwente.nl
Fri Jan 11 07:36:17 UTC 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

~From the commit messages:

- --
Zaurus machine config: fix code for creation of installkit for collie
* remove the code from collie config.  It is present in collie-2.6.inc
- --

That is factually correct, however instead of collie-2.6.inc you mean
zaurus-2.6.inc. Lets see:

koen at bitbake:~/OE/.dev/conf/machine$ grep require collie.conf
require conf/machine/include/collie-${MACHINE_KERNEL_VERSION}.inc
require conf/machine/include/tune-strongarm.inc
koen at bitbake:~/OE/.dev/conf/machine$ grep include collie.conf
require conf/machine/include/collie-${MACHINE_KERNEL_VERSION}.inc
require conf/machine/include/tune-strongarm.inc
koen at bitbake:~/OE/.dev/conf/machine$ grep require include/collie-2.*
koen at bitbake:~/OE/.dev/conf/machine$ grep include include/collie-2.*
koen at bitbake:~/OE/.dev/conf/machine$

Collie doesn't include zaurus-2.6.inc, which is why I added the code to
collie-2.6.inc a while ago so it would actually make an installkit,
which you broke now. Since I want an installkit (I wrote the installkit
code for that reason) I disapproved that commit.


- --
koen at dominion.kabel.utwente.nl will go go away in december 2007, please
use k.kooi at student.utwente.nl instead.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFHhxxxMkyGM64RGpERAjMwAJ9hLuwaCm7LczNWhE6ZxfGuOTeP2wCfUlDB
QSKivkNms6TjC/7CFL2g43g=
=TAlG
-----END PGP SIGNATURE-----




More information about the Openembedded-devel mailing list