[oe] mtn disapprove

[Richard Purdie]

On Sat, 2008-01-12 at 11:42 +0100, Rolf Leggewie wrote: 
> John, thank you for being so observative.  I made the changes to
> tune-strongarm.inc as you suggested.  zImage instead of zImage.bin has
> already been committed a couple of days ago.  In fact it was the commit
> that originally started this thread IIRC.  Thanks again.
> 
> I updated http://oz.leggewie.org/wip/machine-config.diff once more to
> reflect the latest status.

Looks good and is fine with me, some really minor comments inline below:

> --- conf/machine/collie.conf	8ec2568fe9cb9c9b5580adf5e26eb873400e040c
> +++ conf/machine/collie.conf	b40e4db0893370c9b1145d8ad93ca1069a1f1002
> @@ -5,22 +5,18 @@ MACHINE_KERNEL_VERSION ?= "2.6"
[...]
> PREFERRED_PROVIDER_xserver = "xserver-kdrive"
>  
> -# This is needed for the ramdisk script to work
> -MACHINE_EXTRA_RDEPENDS += "e2fsprogs-mke2fs"
> -

What happened to this? It looks wrong, I just want to make sure the
underlying problem was fixed...

> --- conf/machine/include/tune-strongarm.inc	4bb1dc721e55061bb98b49bae4f57bd4ff088f02
> +++ conf/machine/include/tune-strongarm.inc	ffef523af56befe09f34efee482f2cb5677e4caf
> @@ -1,2 +1,3 @@
> -TARGET_CC_ARCH = "-march=armv4 -mtune=xscale"
> +TARGET_CC_ARCH ?= "-march=armv4 -mtune=strongarm1100"
> +TARGET_CC_ARCH_collie = "-march=armv4 -mtune=strongarm1110"

We should really have tune-strongarm1100.inc and
tune-strongarm1110.inc...
 
> --- conf/machine/include/zaurus-2.6.inc	7d4d7255328d5d3f3d61e09ec7b527085533b4d6
> +++ conf/machine/include/zaurus-2.6.inc	88f14d96b91bd44fabb62b5b7c9158ed161774be
> @@ -1,8 +1,9 @@
[...] 
>  TARGET_ARCH = "arm"
> -PACKAGE_EXTRA_ARCHS = "armv4 armv4t armv5e armv5te"
> +PACKAGE_EXTRA_ARCHS ?= "armv4 armv4t armv5e armv5te"
> +PACKAGE_EXTRA_ARCHS_collie = ""

No need for the ?= here...

> @@ -10,20 +11,14 @@ EXTRA_IMAGECMD_jffs2 = "--little-endian 
>  ERASEBLOCKSIZE_akita = "0x20000"
>  
>  EXTRA_IMAGECMD_jffs2 = "--little-endian --eraseblock=${ERASEBLOCKSIZE} --pad --faketime -n" 
> -
>  IMAGE_CMD_jffs2 = "mkfs.jffs2 -x lzo --root=${IMAGE_ROOTFS} --output=${DEPLOY_DIR_IMAGE}/${IMAGE_NAME}.rootfs.jffs2 ${EXTRA_IMAGECMD}"
> -
>  EXTRA_IMAGEDEPENDS += "zaurus-updater"
>  
> -# Use tune-xscale per default. Machine independent feeds should be built with tune-strongarm.
> -include conf/machine/include/tune-xscale.inc
> +SERIAL_CONSOLE ?= "115200 ttyS0"

or here...

Cheers,

Richard