[oe] [PATCH] madwifi-ng_r3837: Fix for LDFLAGS / GNU_HASH QA

Tom Rini trini at embeddedalley.com
Mon Apr 27 17:30:25 UTC 2009


On Mon, Apr 27, 2009 at 06:54:50PM +0200, Leon Woestenberg wrote:
> Hello Tom,
> 
> thanks for your review, and conditional ack, let me try to make it
> unconditional:
> 
> On Mon, Apr 27, 2009 at 3:50 AM, Tom Rini <trini at embeddedalley.com> wrote:
> > On Sun, Apr 26, 2009 at 04:35:04PM -0700, leon.woestenberg at gmail.com wrote:
> >
> >> Submit LDFLAGS variable to make.
> >> Remove the cleaning of LDFLAGS in the binary Makefiles.
> >> Unset LDFLAGS for the kernel modules compile.
> >>
> >> Compile tested on powerpc (mpc8313e-rdb).
> >
> > It's not explicit in the patch, but I assume that what happens now is
> > that LDFLAGS is used for userland utils (good) and the kernel already
> > makes sure this won't leak in as it doesn't pay attention to LDFLAGS at
> > all.  Right?  Or some similar explanation?  If so:
> >
> > Acked-by: Tom Rini <trini at embeddedalley.com>
> >
> 
> Yes, that's what I did. Let me explain the diff in English:

Thanks, unconditioned ack :)

-- 
Tom Rini




More information about the Openembedded-devel mailing list