[oe] [PATCH] gcc_4.2.4.bb: QA Issue: No GNU_HASH in theelf binary

[Tom Rini]

On Wed, Apr 29, 2009 at 06:26:15PM +0200, Stanislav Brabec wrote:
> Tom Rini wrote: 
> > On Wed, Apr 29, 2009 at 08:21:15AM -0400, Philip Balister wrote:
> > > Sledz, Steffen wrote:
> 
> > >> Fix works for me. But it would be nice if some members of the core team could ack it.
> > >
> > > Does anyone see any downside for this patch? Have other people tested  
> > > it? I hate blind acking things.
> > 
> > Khem has a patch for this issue too but wants to test it more.
> 
> I just tested another way to fix. It looks like a gcc bug - LDFLAGS nor
> LDFLAGS_FOR_TARGET are not used in gcc/Makefile.
> 
> diff --git a/recipes/gcc/gcc-configure-common.inc b/recipes/gcc/gcc-configure-common.inc
> index e88cee5..9ede6a2 100644
> --- a/recipes/gcc/gcc-configure-common.inc
> +++ b/recipes/gcc/gcc-configure-common.inc
> @@ -73,7 +73,18 @@ do_configure () {
>  	export CPPFLAGS_FOR_BUILD="${BUILD_CPPFLAGS}"
>  	export CXXFLAGS_FOR_BUILD="${BUILD_CXXFLAGS}"
>  	export LDFLAGS_FOR_BUILD="${BUILD_LDFLAGS}"
>  	export ARCH_FLAGS_FOR_TARGET="${ARCH_FLAGS_FOR_TARGET}"
> +	sed -i 's/^LDFLAGS = $/LDFLAGS = @LDFLAGS@/' ${S}/Makefile.in ${S}/Makefile.tpl
>  	(cd ${S} && gnu-configize) || die "failure running gnu-configize"
>  
>  	# splice our idea of where the headers live into gcc's world
> 
> 
> My previous patch built the whole feed. But I did not test it with
> canadian recipes.

I'll pull this in locally, and build everything today.  Just need to
have the buildbot finish the failure on everything first.

-- 
Tom Rini