[oe] [PATCH] gcc_4.2.4.bb: QA Issue: No GNU_HASH in theelf binary

Stanislav Brabec utx at penguin.cz
Wed Apr 29 17:32:25 UTC 2009


Tom Rini wrote:
> > +	sed -i 's/^LDFLAGS = $/LDFLAGS = @LDFLAGS@/' ${S}/Makefile.in ${S}/Makefile.tpl

> I'll pull this in locally, and build everything today.  Just need to
> have the buildbot finish the failure on everything first.

Well, without "if test -f" it will fail for gcc-4.4.0. This one would be
safer for the final commit. Patching each gcc version separately would
be even more safe, but also more work.

Note: gcc-4.4.0 already contains exactly this fix.

diff --git a/recipes/gcc/gcc-configure-common.inc b/recipes/gcc/gcc-configure-common.inc
index e88cee5..f468a6b 100644
--- a/recipes/gcc/gcc-configure-common.inc
+++ b/recipes/gcc/gcc-configure-common.inc
@@ -74,6 +74,9 @@ do_configure () {
 	export CXXFLAGS_FOR_BUILD="${BUILD_CXXFLAGS}"
 	export LDFLAGS_FOR_BUILD="${BUILD_LDFLAGS}"
 	export ARCH_FLAGS_FOR_TARGET="${ARCH_FLAGS_FOR_TARGET}"
+	# gcc before 4.4.0 ignores LDFLAGS:
+	if test -f ${S}/Makefile.in ; then sed -i 's/^LDFLAGS = $/LDFLAGS = @LDFLAGS@/' ${S}/Makefile.in ; fi
+	if test -f ${S}/Makefile.tpl ; then sed -i 's/^LDFLAGS = $/LDFLAGS = @LDFLAGS@/' ${S}/Makefile.tpl ; fi
 	(cd ${S} && gnu-configize) || die "failure running gnu-configize"
 
 	# splice our idea of where the headers live into gcc's world

-- 
Stanislav Brabec
http://www.penguin.cz/~utx/zaurus





More information about the Openembedded-devel mailing list