[oe] [PATCH] gcc_4.2.4.bb: QA Issue: No GNU_HASH in theelf binary

[Tom Rini]

On Wed, Apr 29, 2009 at 07:32:25PM +0200, Stanislav Brabec wrote:
> Tom Rini wrote:
> > > +	sed -i 's/^LDFLAGS = $/LDFLAGS = @LDFLAGS@/' ${S}/Makefile.in ${S}/Makefile.tpl
> 
> > I'll pull this in locally, and build everything today.  Just need to
> > have the buildbot finish the failure on everything first.
> 
> Well, without "if test -f" it will fail for gcc-4.4.0. This one would be
> safer for the final commit. Patching each gcc version separately would
> be even more safe, but also more work.

OK, some unpacking and grepping and such done.  4.3.x, 4.4.0 and oddly,
4.0.x are good.  The rest are not.  But, I don't see how the if works,
unless ${S} isn't right in gcc-4.4.0, as all versions have
gcc-$VERSION/Makefile.{in,tpl}.

Regardless, I think the approach we should go with is a fixup, per
gcc-version.inc.  Roughly:

do_configure_prepend() {
	# Make sure we don't ignore ldflags.
	sed -i 's/^LDFLAGS = $/LDFLAGS = @LDFLAGS@/' ${S}/Makefile.in
	sed -i 's/^LDFLAGS = $/LDFLAGS = @LDFLAGS@/' ${S}/Makefile.tpl
}

And I'll check if we can drop the incomplete ldflags.patch too.

-- 
Tom Rini