[oe] [PATCH v2 2/2] oe-checksums-sorter.py: speed up about 4X using a hash

Michael Smith msmith at cbnco.com
Tue Jun 30 00:58:46 UTC 2009


OK, this saves a grand total of one second a few times a week, but it
was bugging me...

Signed-off-by: Michael Smith <msmith at cbnco.com>
---
 contrib/source-checker/oe-checksums-sorter.py |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/contrib/source-checker/oe-checksums-sorter.py b/contrib/source-checker/oe-checksums-sorter.py
index ccf76d4..a72b202 100755
--- a/contrib/source-checker/oe-checksums-sorter.py
+++ b/contrib/source-checker/oe-checksums-sorter.py
@@ -87,18 +87,18 @@ if inplace:
 checksums_parser = ConfigParser.ConfigParser()
 checksums_parser.readfp(infp)
 
-item = 1;
-files_total   = len(checksums_parser.sections())
-
 new_list = []
+seen = {}
 
 for source in checksums_parser.sections():
     archive = source.split("/")[-1]
     md5 = checksums_parser.get(source, "md5")
     sha = checksums_parser.get(source, "sha256")
 
-    if new_list.count([archive, source, md5, sha]) < 1:
-        new_list += [[archive, source, md5, sha]]
+    tup = (archive, source, md5, sha)
+    if not seen.has_key(tup):
+        new_list.append(tup)
+        seen[tup] = 1
 
 new_list.sort()
 
-- 
1.6.3





More information about the Openembedded-devel mailing list