[oe] [PATCH] add hotplug2 package

Koen Kooi k.kooi at student.utwente.nl
Tue Mar 31 06:53:24 UTC 2009


On 31-03-09 00:40, Angus Ainslie wrote:

Your commit message is invalid



> +PR = "r0"

r0 is the default so you can remove that


> +DEFAULT_PREFERENCE = "-1"

There's only one version of hotplug2, so why add a default_pref?


> +INITSCRIPT_PARAMS = "start 03 S ."

You forgot to inherit update-rc.d

> +LDFLAGS += "-lglibc"

I don't think that actually works, and if it did, uclibc would break


> +DESTDIR=${D}

missing quotes

> +do_configure () {
> +}

missing colon between the braces. But more importantly: why inherit 
autotools when you're not going to run configure?

regards,

Koen





More information about the Openembedded-devel mailing list