[oe] [PATCH] add hotplug2 package

[Angus Ainslie]

On Tue, 2009-03-31 at 08:53 +0200, Koen Kooi wrote:
> On 31-03-09 00:40, Angus Ainslie wrote:
> 
> Your commit message is invalid
> 
> 

Thanks for pointing out the problem. I would find it helpful if you gave
a hint about what might be invalid. Hopefully this is corrected.


> 
> > +PR = "r0"
> 
> r0 is the default so you can remove that
> 

fixed

> 
> > +DEFAULT_PREFERENCE = "-1"
> 
> There's only one version of hotplug2, so why add a default_pref?
> 

I had 2 on my system but only chose to submit this one. Fixed.

> 
> > +INITSCRIPT_PARAMS = "start 03 S ."
> 
> You forgot to inherit update-rc.d
> 

fixed 

> > +LDFLAGS += "-lglibc"
> 
> I don't think that actually works, and if it did, uclibc would break
> 

Without that I get undefined refeences

 loader.c:(.text+0x14): undefined reference to `dlclose'
 workers/loader.o: In function `worker_load':
 loader.c:(.text+0x44): undefined reference to `dlopen'
 loader.c:(.text+0x5c): undefined reference to `dlsym'
 loader.c:(.text+0x84): undefined reference to `dlerror'

> 
> > +DESTDIR=${D}
> 
> missing quotes
> 

fixed

> > +do_configure () {
> > +}
> 
> missing colon between the braces. But more importantly: why inherit 
> autotools when you're not going to run configure?
> 

I was under the mistaken impression that autotools need to be included
to get do_compile() and do_install(). It seems those are the defaults.

There is a deeper problem that without the inherit autotools then the
LDFLAGS above fails to find glibc. Is there something missing in the
default case ?


> regards,
> 
> Koen
> 

Thanks
Angus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-hotplug2-added-new-recipe-and-updated-checksums.ini.patch
Type: text/x-patch
Size: 2220 bytes
Desc: not available
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20090331/3e269e34/attachment-0005.bin>