[oe] [PATCH] squashfs-4.0: update squashfs-tools to include upstream LZMA inclusion.

[Otavio Salvador]

Hello,

On Wed, Nov 18, 2009 at 2:14 PM, Leon Woestenberg
<leon.woestenberg at gmail.com> wrote:
>> I agree with the move to mainline version however your recipe changes
>> might need some improvement. You don't use the lzma recipe available
>> in OE and instead grab it again ... IMO this is wrong since it
>> duplicates the lzma source and also make more difficult to us to
>> "share" fixes.
>>
> Yes, I noticed this.
>
> However, this is *exactl*y how the squashfs author designed his
> integration of LZMA; simply referring to a specific extracted archive
> of the LZMA SDK.
>
> (consider this is a lazy man's way of static linking)

Anyway I think it is worth fixing it.

Duplicating sources (and the needed fixes, in case LZMA requires one)
is wrong if avoidable so I'd say it would be nice to fix it.

>> Besides that  I think it is ok. Can you fix it and send a new patch for review?
>>
> I will not fix it. Instead I will contact the squashfs author to ask
> if he want to consider the neat approach (if of course LZMA provides
> this).

Look above.

> In the meantime, should I apply the patch as-is?

You already did but I'd expect some time to reply before you pushing it.

:-(

-- 
Otavio Salvador                  O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854         http://projetos.ossystems.com.br