[oe] [PATCH] squashfs-4.0: update squashfs-tools to include upstream LZMA inclusion.

[Leon Woestenberg]

Hello Otavio,

On Wed, Nov 18, 2009 at 7:29 PM, Otavio Salvador
<otavio at ossystems.com.br> wrote:
> On Wed, Nov 18, 2009 at 2:14 PM, Leon Woestenberg
> <leon.woestenberg at gmail.com> wrote:
>>> I agree with the move to mainline version however your recipe changes
>>> might need some improvement. You don't use the lzma recipe available
>>> in OE and instead grab it again ... IMO this is wrong since it
>>> duplicates the lzma source and also make more difficult to us to
>>> "share" fixes.
>>>
>> Yes, I noticed this.
>>
>> However, this is *exactl*y how the squashfs author designed his
>> integration of LZMA; simply referring to a specific extracted archive
>> of the LZMA SDK.
>>
>> (consider this is a lazy man's way of static linking)
>
> Anyway I think it is worth fixing it.
>
Yes, agreed, only if that approach would work (i.e. the needed
functions are correctly exported into the static library)
with the current code base.

> Duplicating sources (and the needed fixes, in case LZMA requires one)
> is wrong if avoidable so I'd say it would be nice to fix it.
>
Duplicating effort working against the upstream package is wrong too.
I would rather
go through the author to see this approach mainlined.


>> In the meantime, should I apply the patch as-is?
> You already did but I'd expect some time to reply before you pushing it.
>
Sorry I misunderstood your "good and thx" reply on IRC.
The current lzma recipe has some problems (use of dos2unix, not
building for target) that we need to fix first.

The currently committed recipe is pure metadata, builds the same way
as the upstream package does, and is tested for -native on a target,
by booting a squashfs-lzma compressed rootfs.
I propose to keep it as-is, then see if we can fix lzma, neaten the
squashfs-tools build, and bring it upstream.

Regards,
-- 
Leon