[oe] [PATCH]Removing Legacy staging from genboot native recipe

[Paul Menzel]

Am Freitag, den 13.08.2010, 17:17 +0600 schrieb noor_ahsan at mentor.com:
> genboot-native: Removing legacy staging

You used `git-send-email`, but it looks strange since this line should
have been the subject line and not in the commit message.

Please also mark iteration of your patches. For example this with »PATCH
v2«. (See `--subject-prefix` in `git help format-patch`.) For clarity
also add a small comment, what changed after the S-o-b line like below
when you use `git commit`.

> * Replaced do_stage function with do_install and replaced ${STAGING_BINDIR} with ${D}${bindir}
>  
> Signed-off-by: Noor Ahsan <noor_ahsan at mentor.com>
---
v2: Increase `PR`.
---

> diff --git a/recipes/simpad-utilities/genboot-native.bb b/recipes/simpad-utilities/genboot-native.bb
> index 47b9b34..f398a55 100644
> --- a/recipes/simpad-utilities/genboot-native.bb
> +++ b/recipes/simpad-utilities/genboot-native.bb
> @@ -1,5 +1,5 @@
>  SECTION = "console/utils"
> -PR = "r1"
> +PR = "r2"
>  DESCRIPTION = "Console utility for generating a SIMpad boot image for the proprietary SIEMENS Switzerland bootloader"
>  FILESDIR = "${@os.path.dirname(bb.data.getVar('FILE',d,1))}/genboot"
>  SRC_URI = "file://gen_boot.c file://arnold_boot.h file://simpad-make-flashimg"
> @@ -9,12 +9,15 @@ DEPENDS = "pad-native"
>  
>  inherit native
>  
> +NATIVE_INSTALL_WORKS = "1"

I am really a noob, but is not that for “normal”, i.e. no *-native,
recipes indicating no explicit native recipe is needed?

>  do_compile() {
> -	cp ${WORKDIR}/*.h ${WORKDIR}/*.c .
> -	${CC} -I. -o genboot gen_boot.c
> +        cp ${WORKDIR}/*.h ${WORKDIR}/*.c .
> +        ${CC} -I. -o genboot gen_boot.c
>  }

You changed the whitespace. I do not know if there are any
rules/recommendations in OE, but it bloats up the patch.

> -do_stage() {
> -	install -m 0755 genboot ${STAGING_BINDIR}/
> -	install -m 0755 ${WORKDIR}/simpad-make-flashimg ${STAGING_BINDIR}/
> +do_install() {
> +        install -d ${D}${bindir}/
> +        install -m 0755 genboot ${D}${bindir}/
> +        install -m 0755 ${WORKDIR}/simpad-make-flashimg ${D}${bindir}/
>  }


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20100813/5f00c6e3/attachment-0002.sig>