[oe] [PATCH]Removing Legacy staging from genboot native recipe

[Frans Meulenbroeks]

2010/8/13 Paul Menzel <paulepanter at users.sourceforge.net>:
> Am Freitag, den 13.08.2010, 17:17 +0600 schrieb noor_ahsan at mentor.com:
>> genboot-native: Removing legacy staging
>
> You used `git-send-email`, but it looks strange since this line should
> have been the subject line and not in the commit message.
>
> Please also mark iteration of your patches. For example this with »PATCH
> v2«. (See `--subject-prefix` in `git help format-patch`.) For clarity
> also add a small comment, what changed after the S-o-b line like below
> when you use `git commit`.

agree

>
>> * Replaced do_stage function with do_install and replaced ${STAGING_BINDIR} with ${D}${bindir}
>>
>> Signed-off-by: Noor Ahsan <noor_ahsan at mentor.com>
> ---
> v2: Increase `PR`.
> ---
>
>> diff --git a/recipes/simpad-utilities/genboot-native.bb b/recipes/simpad-utilities/genboot-native.bb
>> index 47b9b34..f398a55 100644
>> --- a/recipes/simpad-utilities/genboot-native.bb
>> +++ b/recipes/simpad-utilities/genboot-native.bb
>> @@ -1,5 +1,5 @@
>>  SECTION = "console/utils"
>> -PR = "r1"
>> +PR = "r2"
>>  DESCRIPTION = "Console utility for generating a SIMpad boot image for the proprietary SIEMENS Switzerland bootloader"
>>  FILESDIR = "${@os.path.dirname(bb.data.getVar('FILE',d,1))}/genboot"
>>  SRC_URI = "file://gen_boot.c file://arnold_boot.h file://simpad-make-flashimg"
>> @@ -9,12 +9,15 @@ DEPENDS = "pad-native"
>>
>>  inherit native
>>
>> +NATIVE_INSTALL_WORKS = "1"
>
> I am really a noob, but is not that for “normal”, i.e. no *-native,
> recipes indicating no explicit native recipe is needed?

Afaik this is not needed.

>
>>  do_compile() {
>> -     cp ${WORKDIR}/*.h ${WORKDIR}/*.c .
>> -     ${CC} -I. -o genboot gen_boot.c
>> +        cp ${WORKDIR}/*.h ${WORKDIR}/*.c .
>> +        ${CC} -I. -o genboot gen_boot.c
>>  }
>
> You changed the whitespace. I do not know if there are any
> rules/recommendations in OE, but it bloats up the patch.

It indeed bloats. What happens is that tabs have been converted to
spaces (probably using oe-stylize.py). This is the preferred way in
oe.
We discussed this on irc and advised Noor to use spaces and/or oe-stylize.

Frans
>
>> -do_stage() {
>> -     install -m 0755 genboot ${STAGING_BINDIR}/
>> -     install -m 0755 ${WORKDIR}/simpad-make-flashimg ${STAGING_BINDIR}/
>> +do_install() {
>> +        install -d ${D}${bindir}/
>> +        install -m 0755 genboot ${D}${bindir}/
>> +        install -m 0755 ${WORKDIR}/simpad-make-flashimg ${D}${bindir}/
>>  }
>
>
> Thanks,
>
> Paul
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>
>