[oe] [PATCH 2/2] recipes: Update recipes to get 'bitbake world' parse and calculate runqueue successfully.

[Khem Raj]

On Fri, Aug 27, 2010 at 2:40 AM, Frans Meulenbroeks
<fransmeulenbroeks at gmail.com> wrote:
> Khem,
>
> Thanks for the good work.
> I've gone through the file and saw no problems.
> The move of the nonbuilding recipes due to missing dependencies (like
> with hildon) has been discussed on irc too).
> I have a few small remarks (see below), but nothing blocking an ack so,
> Acked-by: Frans Meulenbroeks <fransmeulenbroeks at gmail.com>
>
> Btw: next time please split things like this in two:

yes would have been better.

> one patch with the files that are moved and one patch with the files
> that are modified.
> That makes it easier to review the modified recipes.
>
>> diff --git a/recipes/angstrom/angstrom-bootmanager.bb b/recipes/angstrom/angstrom-bootmanager.bb
>> index 6cae115..e5f3478 100644
>> --- a/recipes/angstrom/angstrom-bootmanager.bb
>> +++ b/recipes/angstrom/angstrom-bootmanager.bb
>> @@ -1,7 +1,7 @@
>>  DESCRIPTION = "A graphical Boot Manager for the Ångström Linux Distribution"
>>  AUTHOR = "Michael 'Mickey' Lauer <mickey at Vanille.de>"
>>  SECTION = "base"
>> -DEPENDS = "evas-fb ecore-fb esmart-fb imlib2-fb edje efl++-fb"
>> +#DEPENDS = "ecore esmart-fb imlib2-fb edje efl++-fb"
>>  #RDEPENDS_${PN} = "libefl++0"
>>
>>  ALLOW_EMPTY = "1"
>
> I'm not too keen on commenting out things. If it is not needed any
> more it should just go.

It could but I do not claim to know it well.
so I will leave that to someone else.

> Something like the lines above only cause confusion.
> suggest to remove the # lines or to add a short comment explaining why
> they are commented out but not removed.

I can add comments yes will do.

>
>
>> diff --git a/recipes/xqt2/xqt2_20060509.bb b/recipes/xqt2/xqt2_20060509.bb
>> index 7634d27..4492bc7 100644
>> --- a/recipes/xqt2/xqt2_20060509.bb
>> +++ b/recipes/xqt2/xqt2_20060509.bb
>> @@ -1,6 +1,6 @@
>>  DESCRIPTION = "Xqt2 is an X-Server than runs within the Opie environment"
>>  HOMEPAGE = "http://xqt.sourceforge.jp"
>> -DEPENDS = "freetype libxi xmu flex-native virtual/libqte2 libqpe-opie"
>> +DEPENDS = "freetype libxi libxmu flex-native virtual/libqte2 libqpe-opie"
>>  LICENSE = "GPL"
>>  SECTION = "opie/applications"
>>  APPTYPE = "binary"
>> --
>> 1.7.1
>
> With recipes like this I always wonder if we should keep them.
> Apparently they are not build, otherwise the faulty DEPENDS would have
> been detected earlier.

very true. But that is another step.

> And the fact that it is a recipe from 2006 also indicates it is
> probably not important.
> Can an opie maintainer say whether it is useful to keep this?
>
> Thanks for the good work!

thx for looking into it.
> Frans
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>