[oe] TSC Meeting 7/1/2010

[Frans Meulenbroeks]

Richard, Thanks for making the minutes available.

A short reaction on a few things:
>
> Current Issues
> ==============
>
> We did discuss the IMAGE_BOOT issue. We decided that weak defaults (?=)
> in the class where the variables are used is a good thing and that the
> current structure is pretty much inline with that for image.bbclass. The
> IMAGE_BOOT change could have been better thought out but we're stuck
> with it now with no real options for changing it.

I guess the IMAGE_BOOT issue is the defaulting to udev issue. Anyway
it seems good to briefly explain the issue.

Is there a rationale why (in this case) weak defaults were considered
a good thing?
Personally I would prefer no defaults as an image recipe can easily
define them themselves (perhaps using an include of udev.inc or so).
In any case I feel if there are defaults the existence of the default
and perhaps some rationale should be documented (in the cookbook?).
I think we may expect that someone doing a recipe reads the cookbook,
but it should not be required to go through the class code to find out
about defaults etc.

(btw and if IMAGE_BOOT is not the "default use udev" issue I suggest
to table the latter topic).

>
> Commit messages were mentioned. It should be clear from reading the
> commit message what the change applies to and why its necessary. The TSC
> will start naming and shaming people making lousy commit messages and
> reserve the right to impose sanctions against repeat offenders.

I agree that we want good commit messages.

Some remarks though:

Before publicly naming and shaming people, I would suggest discussing
it with the offender in private email or on irc.
Naming and shaming might drive people away from oe.

I suggest that when someone gets commit rights (s)he is explicity
reminded of http://wiki.openembedded.net/index.php/Commit_Policy and
http://wiki.openembedded.net/index.php/Commit_log_example

I suggest to review the rules;. E.g. this one:
# This should all be on one line and you should leave an empty line
before any detailed commit information.
Nice, but if you use git commit and enter your message empty lines are removed.

Also i suggest an additional rule that commit messages should be polite.
E.g. no snide remarks on someone who made an earlier patch or on the
source package or on the code itself.

Frans