[oe] [PATCH] linux-storcenter: add fw-and-powerpc-install.patch
Guo Hongruan
camelguo at gmail.com
Sat Jan 23 10:22:27 UTC 2010
在 Sat, 23 Jan 2010 18:03:40 +0800,Paul Menzel
<paulepanter at users.sourceforge.net> 写道:
> Am Samstag, den 23.01.2010, 17:53 +0800 schrieb Guo Hongruan:
>> the building of linux-storcenter_2.6.27.7 failed due to lack of this
>> patch
>
> I think Holger meant, what the patch is doing. Maybe it is not needed
> and you can remove it from `SRC_URI`.
I just copied it from linux-orion directory. This patch just adds space
between '-m' and 'mode'. (see the patch) On my ubuntu-8.04, 'install
-m0644' is the same as 'install -m 0644', so this patch can be removed
from SRC_URI. But I don't know whether or not it is an issue on other
linux operation systems.
By the way, I found it in the following recipes, all of them are for ppc
arch.
linux-linkstationppc_2.6.28.4.bb:
file://fw-and-powerpc-install.patch;patch=1 \
linux-orion_2.6.28.4.bb:
file://fw-and-powerpc-install.patch;patch=1 \
linux-storcenter_2.6.27.7.bb:
file://fw-and-powerpc-install.patch;patch=1 \
So, I just copy it into linux-storcenter.
>
> That said, firstly Holger probably did not see that the patch is copied
> from somewhere else in the repository. The question is if it is
> recommended to note in the commit message from where it is copied or if
> Git should be used to determine this.
Yes, I understand. I should tell where I copied it from
>
> The second thing is, that the patch from `SRC_URI` is missing a header
> with the description of its purpose [1]. But since it is copied it has
> been so before.
>
>
> Thanks,
>
> Paul
>
>
> [1] http://wiki.openembedded.net/index.php/Push_patches_upstream
--
Guo Hongruan, Embedded Linux Consultant
Skype: camelguo
Twitter: camelguo
http://www.gulessoft.com
More information about the Openembedded-devel
mailing list