[oe] [PATCH] linux-storcenter: add fw-and-powerpc-install.patch

[Holger Hans Peter Freyther]

On Saturday 23 January 2010 11:22:27 Guo Hongruan wrote:
> 在 Sat, 23 Jan 2010 18:03:40 +0800，Paul Menzel
> 
> <paulepanter at users.sourceforge.net> 写道:
> > Am Samstag, den 23.01.2010, 17:53 +0800 schrieb Guo Hongruan:
> >> the building of linux-storcenter_2.6.27.7 failed due to lack of this
> >> patch
> >
> > I think Holger meant, what the patch is doing. Maybe it is not needed
> > and you can remove it from `SRC_URI`.
> 
> I just copied it from linux-orion directory. This patch just adds space
> between '-m' and 'mode'. (see the patch) On my ubuntu-8.04, 'install
> -m0644' is the same as 'install -m 0644', so this patch can be removed
>  from SRC_URI. But I don't know whether or not it is an issue on other
> linux operation systems.

This was a general remark on commit messages. I wanted to point out
that your commit message does not say anything and this normally means
if you are not able to say what the issue is you don't understand it yourself.

So from this thread and the fact you were copying the file it means. That the
current "linux-storcenter" recipe is failing in the do_patch phase because the
file can not be found?

The first thing to note is your commit message should include the problem
you are trying to fix! Now the second thing is to figure out to fix it. E.g. 
where is the SRC_URI touched? Maybe it does make sense to copy the patch to 
recipes/linux/files? Or to version it as well? Or maybe it is not needed at 
all?

I would really appreciate if you could put some more care into the patches you 
are writing, this starts with the commit message and should be continued with 
the content of the patch itself.


thanks
	z.