[oe] Patchwork Workflow improvement

[Holger Hans Peter Freyther]

On Saturday 23 January 2010 11:42:56 Koen Kooi wrote:

> > 1.) Cherry pick from the branch
> > 2.) Send updated patches, close the reports on patchwork...
> 
> I think people that apply those patches to oe.dev should fix up the
> commit message as well. The stack Khem pushed this week is just awfull.

Right... cherry-pick and use git commit --amend afterwards



> 
> I guess we should flag patches with bad commit messages as 'rejected' in
> pw ASAP. We can weed out most of them by reject anything that lacks a
> ':' in the subject line.

that is a difficult decision. E.g.  of course we should handle patches that have 
a good commit message faster than patches that are of lower quality. But then 
again just rejecting a patch is also bad, e.g. maybe the contributor just 
didn't know better and needs a helpful hand?

I was going through them older stuff, e.g. someone sending a patch against a 
package but not as part of a fix to the recipe... So the contributor did his 
homework, he looked for similiar build errors and found a patch, it is low 
hanging fruit to fix that in OE.


The bottom line is. People don't send us "bad" patches to piss us off, they try 
to contribute and we should help them to be useful contributors.

z.