[oe] New state for patches not complying with commit policy

Koen Kooi k.kooi at student.utwente.nl
Sat Jan 23 18:00:42 UTC 2010


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 23-01-10 17:11, Phil Blundell wrote:
> On Sat, 2010-01-23 at 13:19 +0100, Paul Menzel wrote:
>> If it is possible, I suggest to add a new state (»Rejected – Commit
>> Policy«) for patches not complying with the commit policy [3]?
> 
> If the patch is basically correct then it seems a little bit officious
> to reject it purely because it fails to conform to the commit policy in
> some way.  Most of the issues listed in the policy are easy enough to
> fix up when applying the patch, after all.

And yet OE developers aren't fixing those up (latest example: the patch
stack Khem pushed last week), however easy it may be.

Maybe it's a case of sampling bias since I only inspect bad commits, but
in any case, the commit message of the commits that end up in .dev needs
to get improved.

regards,

Koen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Darwin)

iD8DBQFLWzlJMkyGM64RGpERAvyDAKCE7pBD3krfl2wBN4GvYi59Wi+g8wCeLNmA
Wg9qotVtOlkyOtLgSkhTrPQ=
=ar+b
-----END PGP SIGNATURE-----





More information about the Openembedded-devel mailing list