[oe] [PATCH 2/2] base.bbclass: don't pre-generate checksums.ini entries any longer

Frans Meulenbroeks fransmeulenbroeks at gmail.com
Mon Jan 25 07:24:11 UTC 2010


2010/1/25 Khem Raj <raj.khem at gmail.com>:
> On Sun, Jan 24, 2010 at 5:59 PM, Denys Dmytriyenko <denis at denix.org> wrote:
>> Signed-off-by: Denys Dmytriyenko <denis at denix.org>
>> ---
>>  classes/base.bbclass |   15 +--------------
>>  1 files changed, 1 insertions(+), 14 deletions(-)
>>
>> diff --git a/classes/base.bbclass b/classes/base.bbclass
>> index 8465286..8e14636 100644
>> --- a/classes/base.bbclass
>> +++ b/classes/base.bbclass
>> @@ -140,18 +140,7 @@ def base_chk_file(parser, pn, pv, src_uri, localpath, data):
>>     except OSError:
>>         raise Exception("Executing shasum failed")
>>
>> -    if no_checksum == True:    # we do not have conf/checksums.ini entry
>> -        try:
>> -            file = open("%s/checksums.ini" % bb.data.getVar("TMPDIR", data, 1), "a")
>> -        except:
>> -            return False
>> -
>> -        if not file:
>> -            raise Exception("Creating checksums.ini failed")
>> -
>> -        file.write("[%s]\nmd5=%s\nsha256=%s\n\n" % (src_uri, md5data, shadata))
>> -        file.close()
>> -
>> +    if no_checksum == True:    # we do not have SRC_URI checksums
>>         from string import maketrans
>>         trtable = maketrans("", "")
>>         uname = src_uri.split("/")[-1].translate(trtable, "-+._")
>> @@ -168,8 +157,6 @@ def base_chk_file(parser, pn, pv, src_uri, localpath, data):
>>         ufile.close()
>>
>>         if not bb.data.getVar("OE_STRICT_CHECKSUMS",data, True):
>> -            bb.note("This package has no entry in checksums.ini, please add one")
>> -            bb.note("\n[%s]\nmd5=%s\nsha256=%s" % (src_uri, md5data, shadata))
>>             bb.note("This package has no checksums in corresponding recipe, please add")
>>             bb.note("SRC_URI = \"%s;name=%s\"\nSRC_URI[%s.md5sum] = \"%s\"\nSRC_URI[%s.sha256sum] = \"%s\"\n" % (src_uri, uname, uname, md5data, uname, shadata))
>>             return True
>> --
>
> OK
>
> Acked-by: Khem Raj <raj.khem at gmail.com>

Do we want to do this at this point? Or say in a week (or two) after
people got acquainted  to the new format.

Btw: I'm not really a script kiddie, but I guess it should not be too
difficult to cook up a script to update the recipes so we can abandon
checksums.ini
(two mechanisms does not seem to be the right way).
Any takers?

Frans




More information about the Openembedded-devel mailing list