[oe] {RFC] console-image.bb

[Paul Menzel]

Am Samstag, den 30.01.2010, 16:23 +0100 schrieb Koen Kooi:
> On 30-01-10 11:35, Frans Meulenbroeks wrote:
> > Today I bumped into console-image and noticed the following:
> > 
> > IMAGE_INSTALL = "task-base \
> >             ${ANGSTROM_EXTRA_INSTALL} \
> >             ${SPLASH} \
> >             ${ZZAPSPLASH} \
> > 
> > Wouldn't it be cleaner to rename ANGSTROM_EXTRA_INSTALL to e.g.
> > DISTRO_EXTRA_INSTALL ?
> > This under the assumption that console-image is a distro independent
> recipe.
> > 
> > Or, in case this is an angstrom specific recipe shouldn't it be
> better
> > named angstrom-console-image ?
> > 
> > your views are appreciated :-)
> 
> I vote for leaving it as it is, it gives some credit to where it
> originated from. The image name already has been forcefully renamed to
> strip out 'angstrom' so lets keep at least this bit of heritage.

I think the VCS (Git) is a good tool to find out where something like
this originated from.

> Besides, who's going to fix all users of ANGSTROM_EXTRA_INSTALL? 

Good question. I think `sed` should be good enough for this. Otherwise
someone has to decide if it is better to confuse new users or to put
some work on old users to update the variable name.


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Dies ist ein digital signierter Nachrichtenteil
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20100130/e02cce36/attachment-0002.sig>