[oe] [RFC] remove unused svn-updates.dpatch files

[Frans Meulenbroeks]

2010/3/1 Graham Gower <graham.gower at gmail.com>:
> On 2 March 2010 07:57, Frans Meulenbroeks <fransmeulenbroeks at gmail.com> wrote:
>> 2010/3/1 Denys Dmytriyenko <denis at denix.org>:
>>> On Mon, Mar 01, 2010 at 08:10:31AM +1030, Graham Gower wrote:
>>
>>>> What should offend you more is stuff like this:
>>>>
>>>> [grg at rak gcc]$ pwd
>>>> /home/grg/oe/openembedded/recipes/gcc
>>>> [grg at rak gcc]$ find . -name svn-updates.dpatch -exec ls -l {} \;
>>>> -rw-r--r-- 1 grg users 17668056 2009-11-15 12:59
>>>> ./gcc-4.4.2/debian/svn-updates.dpatch
>>>> -rw-r--r-- 1 grg users 17668056 2009-11-15 12:59
>>>> ./gcc-4.4.1/debian/svn-updates.dpatch
>>>> -rw-r--r-- 1 grg users 17668056 2009-11-15 12:59
>>>> ./gcc-4.3.1/debian/svn-updates.dpatch
>>>> -rw-r--r-- 1 grg users 17668056 2009-11-15 12:59
>>>> ./gcc-4.3.3/debian/svn-updates.dpatch
>>>> -rw-r--r-- 1 grg users 17668056 2009-11-15 12:59
>>>> ./gcc-4.3.4/debian/svn-updates.dpatch
>>>> -rw-r--r-- 1 grg users 17668056 2009-11-15 12:59
>>>> ./gcc-svn/debian/svn-updates.dpatch
>>>> -rw-r--r-- 1 grg users 17668056 2009-11-15 12:59
>>>> ./gcc-4.3.2/debian/svn-updates.dpatch
>>>> [grg at rak gcc]$ grep svn-updates *
>>>> [grg at rak gcc]$
>>>
>>> So, there is 125 MB wasted right there... Thanks for the heads up! :)
>>
>> Checked it and the 4.4.[12] and gcc-svn versions are gone.
>> the gcc-4.3.[1-4] versions are still there but seem unused:
>>
>> frans at linux-suse:~/oe/openembedded/recipes/gcc> grep -r svn-updates.dpatch .
>> frans at linux-suse:~/oe/openembedded/recipes/gcc>
>>
>> Howvever as gcc is quite core, I'd rather verify first that it is ok
>> to remove them
>> (or can someone with more gcc knowledge remove)
>>
>> Frans.
>>
>> _______________________________________________
>> Openembedded-devel mailing list
>> Openembedded-devel at lists.openembedded.org
>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>
>
> Perhaps there are other patches in the debian directories that are also unused?
>
> -Graham

Some of them definitely are:

I picked a random example:
./gcc-4.3.2/debian/hurd-changes.dpatch

frans at linux-suse:~/oe/openembedded/recipes/gcc> grep -r hurd-changes.dpatch .
frans at linux-suse:~/oe/openembedded/recipes/gcc>

Actually I suspect that almost all files in the debian dirs are deadweight:
frans at linux-suse:~/oe/openembedded/recipes/gcc> grep debian *
gcc-4.3.1.inc:    file://debian/arm-unbreak-eabi-armv4t.dpatch;patch=1 \
gcc-4.3.1.inc:	file://debian/libstdc++-pic.dpatch;patch=1;pnum=0 \
gcc-4.3.1.inc:	file://debian/gcc-ice-hack.dpatch;patch=1;pnum=0 \
gcc-4.3.1.inc:	file://debian/pr30961.dpatch;patch=1;pnum=0 \
gcc-4.3.2.inc:    file://debian/arm-unbreak-eabi-armv4t.dpatch;patch=1 \
gcc-4.3.2.inc:	file://debian/libstdc++-pic.dpatch;patch=1;pnum=0 \
gcc-4.3.2.inc:	file://debian/gcc-ice-hack.dpatch;patch=1;pnum=0 \
gcc-4.3.2.inc:	file://debian/pr30961.dpatch;patch=1;pnum=0 \
gcc-4.3.3.inc:	file://debian/arm-unbreak-eabi-armv4t.dpatch;patch=1 \
gcc-4.3.3.inc:	file://debian/libstdc++-pic.dpatch;patch=1;pnum=0 \
gcc-4.3.3.inc:	file://debian/gcc-ice-hack.dpatch;patch=1;pnum=0 \
gcc-4.3.3.inc:	file://debian/pr30961.dpatch;patch=1;pnum=0 \
gcc-4.3.4.inc:	file://debian/arm-unbreak-eabi-armv4t.dpatch;patch=1 \
gcc-4.3.4.inc:	file://debian/libstdc++-pic.dpatch;patch=1;pnum=0 \
gcc-4.3.4.inc:	file://debian/gcc-ice-hack.dpatch;patch=1;pnum=0 \
gcc-4.3.4.inc:	file://debian/pr30961.dpatch;patch=1;pnum=0 \
frans at linux-suse:~/oe/openembedded/recipes/gcc>

So we use 4 of them.
and e.g. gcc-4.3.4/debian has 85 files in it:
frans at linux-suse:~/oe/openembedded/recipes/gcc> ls gcc-4.3.4/debian | wc
     85      85    1873

Frans