[oe] [RFC] remove unused svn-updates.dpatch files

Khem Raj raj.khem at gmail.com
Mon Mar 1 21:59:03 UTC 2010


On Mon, Mar 1, 2010 at 1:44 PM, Frans Meulenbroeks
<fransmeulenbroeks at gmail.com> wrote:
> 2010/3/1 Khem Raj <raj.khem at gmail.com>:
>> On Mon, Mar 1, 2010 at 1:35 PM, Graham Gower <graham.gower at gmail.com> wrote:
>>> On 2 March 2010 07:57, Frans Meulenbroeks <fransmeulenbroeks at gmail.com> wrote:
>>>> 2010/3/1 Denys Dmytriyenko <denis at denix.org>:
>>>>> On Mon, Mar 01, 2010 at 08:10:31AM +1030, Graham Gower wrote:
>>>>
>>>>>> What should offend you more is stuff like this:
>>>>>>
>>>>>> [grg at rak gcc]$ pwd
>>>>>> /home/grg/oe/openembedded/recipes/gcc
>>>>>> [grg at rak gcc]$ find . -name svn-updates.dpatch -exec ls -l {} \;
>>>>>> -rw-r--r-- 1 grg users 17668056 2009-11-15 12:59
>>>>>> ./gcc-4.4.2/debian/svn-updates.dpatch
>>>>>> -rw-r--r-- 1 grg users 17668056 2009-11-15 12:59
>>>>>> ./gcc-4.4.1/debian/svn-updates.dpatch
>>>>>> -rw-r--r-- 1 grg users 17668056 2009-11-15 12:59
>>>>>> ./gcc-4.3.1/debian/svn-updates.dpatch
>>>>>> -rw-r--r-- 1 grg users 17668056 2009-11-15 12:59
>>>>>> ./gcc-4.3.3/debian/svn-updates.dpatch
>>>>>> -rw-r--r-- 1 grg users 17668056 2009-11-15 12:59
>>>>>> ./gcc-4.3.4/debian/svn-updates.dpatch
>>>>>> -rw-r--r-- 1 grg users 17668056 2009-11-15 12:59
>>>>>> ./gcc-svn/debian/svn-updates.dpatch
>>>>>> -rw-r--r-- 1 grg users 17668056 2009-11-15 12:59
>>>>>> ./gcc-4.3.2/debian/svn-updates.dpatch
>>>>>> [grg at rak gcc]$ grep svn-updates *
>>>>>> [grg at rak gcc]$
>>>>>
>>>>> So, there is 125 MB wasted right there... Thanks for the heads up! :)
>>>>
>>>> Checked it and the 4.4.[12] and gcc-svn versions are gone.
>>>> the gcc-4.3.[1-4] versions are still there but seem unused:
>>>>
>>>> frans at linux-suse:~/oe/openembedded/recipes/gcc> grep -r svn-updates.dpatch .
>>>> frans at linux-suse:~/oe/openembedded/recipes/gcc>
>>>>
>>>> Howvever as gcc is quite core, I'd rather verify first that it is ok
>>>> to remove them
>>>> (or can someone with more gcc knowledge remove)
>>>>
>>>> Frans.
>>>>
>>>> _______________________________________________
>>>> Openembedded-devel mailing list
>>>> Openembedded-devel at lists.openembedded.org
>>>> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>>>>
>>>
>>> Perhaps there are other patches in the debian directories that are also unused?
>>>
>>
>> yes I did clean few of later releases but not older ones. From cloning
>> point it does not reduce anything
>> because the files will be there in repo but I cleaned up later
>> versions because for adding recipes for newer releases from here on
>> copying patch directories will save us adding unused new files.
>>
>> Thanks
>>
> Are you in favor of cleaning up 4.3.* too?
> Although it does not help from cloning point it does not clutter the
> dir and distract people from the real patches.

In gcc patches are unapplied and each patch might and sometimes it
helps to see them in there if they are unused because they give you
idea and sometimes they are the fixes, so I am neutral to such
cleanups for me they don't mean much but I understand
your point too.

> FM
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel
>




More information about the Openembedded-devel mailing list