[oe] [PATCH] bitbake.conf: don't append MACHINE_OVERRIDES to OVERRIDES when it's empty

[Maupin, Chase]

> -----Original Message-----
> From: openembedded-devel-bounces at lists.openembedded.org
> [mailto:openembedded-devel-bounces at lists.openembedded.org] On Behalf Of
> Chris Larson
> Sent: Tuesday, October 19, 2010 2:09 PM
> To: openembedded-devel at lists.openembedded.org
> Subject: Re: [oe] [PATCH] bitbake.conf: don't append MACHINE_OVERRIDES to
> OVERRIDES when it's empty
> 
> On Tue, Oct 19, 2010 at 12:05 PM, Maupin, Chase <chase.maupin at ti.com>
> wrote:
> 
> > > -----Original Message-----
> > > From: openembedded-devel-bounces at lists.openembedded.org
> > > [mailto:openembedded-devel-bounces at lists.openembedded.org] On Behalf
> Of
> > > Martin Jansa
> > > Sent: Saturday, October 16, 2010 2:25 PM
> > > To: openembedded-devel at lists.openembedded.org
> > > Subject: [oe] [PATCH] bitbake.conf: don't append MACHINE_OVERRIDES to
> > > OVERRIDES when it's empty
> > >
> > > * empty MACHINE_OVERRIDES adds :: to OVERRIDES (then in FILESPATH
> skips
> > >   every directory after this)
> > > * strip() is needed to remove space in case some distribution has ie
> > >   MACHINE_OVERRIDES ?= ""
> > >   and then
> > >   MACHINE_OVERRIDES += ""
> > >   or
> > >   MACHINE_OVERRIDES ?= "${MACHINE_CLASS}", where MACHINE_CLASS is
> empty
> > > again
> >
> > I saw this issue in my overlay of having a "::" in my OVERRIDES which
> > caused my parsing to fail in angstrom.inc.  Applying this fix from
> Martin
> > resolves the parsing issue.  My OVERRIDES appear to be in the correct
> order
> > with this change:
> 
> 
> Can you explain this?  "caused my parsing to fail" is not very useful
> information.  What exactly failed?

Chris,

Sorry, I thought this was an understood issue.  I have put the error output I got below.  Basically, when I got to line 509 of data.py the variables had the following values:

vars = set(['__functions_', '_', '__functions__'])

var = '__functions__'

overrides = ['pn-angstrom', 'fail-fast', 'build-linux', 'arm', 'INVALID', 'angstrom-2008.1', '', 'am37x-evm', 'local']
 
o = ''

OVERRIDES = 'pn-angstrom:fail-fast:build-linux:arm:INVALID:angstrom-2008.1::am37x-evm:local'

The current override being evaluated was the '' one.

The line being evaluated in my overlay was USERDISTRO := "${DISTRO}" in my copy of angstrom.inc

The output from my build was:

a0271661 at sdit-build01:~/projects/arago-multi-build$ bitbake helloworldTraceback (most recent call last):
  File "/home/a0271661/projects/arago-multi-build/arago-bitbake/bin/bitbake", line 143, in <module>
    main()
  File "/home/a0271661/projects/arago-multi-build/arago-bitbake/bin/bitbake", line 123, in main
    cooker.parseConfiguration()
  File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/cooker.py", line 68, in parseConfiguration
    self.parseConfigurationFile( os.path.join( "conf", "bitbake.conf" ) )
  File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/cooker.py", line 390, in parseConfigurationFile
    self.configuration.data = bb.parse.handle( afile, self.configuration.data )
  File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/__init__.py", line 75, in handle
    return h['handle'](fn, data, include)
  File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/parse_py/ConfHandler.py", line 167, in handle
    feeder(lineno, s, fn, data)
  File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/parse_py/ConfHandler.py", line 215, in feeder
    include(fn, s, data, False)
  File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/parse_py/ConfHandler.py", line 114, in include
    ret = handle(fn, data, True)
  File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/__init__.py", line 75, in handle
    return h['handle'](fn, data, include)
  File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/parse_py/ConfHandler.py", line 167, in handle
    feeder(lineno, s, fn, data)
  File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/parse_py/ConfHandler.py", line 221, in feeder
    include(fn, s, data, "include required")
  File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/parse_py/ConfHandler.py", line 114, in include
    ret = handle(fn, data, True)
  File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/__init__.py", line 75, in handle
    return h['handle'](fn, data, include)
  File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/parse_py/BBHandler.py", line 175, in handle
    feeder(lineno, s, fn, base_name, d)
  File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/parse_py/BBHandler.py", line 381, in feeder
    return ConfHandler.feeder(lineno, s, fn, d)
  File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/parse_py/ConfHandler.py", line 192, in feeder
    bb.data.update_data(e)
  File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/data.py", line 509, in update_data
    for var in vars:
RuntimeError: Set changed size during iteration

> --
> Christopher Larson
> clarson at kergoth dot com
> Founder - BitBake, OpenEmbedded, OpenZaurus
> Maintainer - Tslib
> Senior Software Engineer, Mentor Graphics
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel