[oe] [PATCH] bitbake.conf: don't append MACHINE_OVERRIDES to OVERRIDES when it's empty

[Denys Dmytriyenko]

On Tue, Oct 19, 2010 at 02:18:25PM -0500, Maupin, Chase wrote:
> > > I saw this issue in my overlay of having a "::" in my OVERRIDES which
> > > caused my parsing to fail in angstrom.inc.  Applying this fix from
> > Martin
> > > resolves the parsing issue.  My OVERRIDES appear to be in the correct
> > order
> > > with this change:
> > 
> > Can you explain this?  "caused my parsing to fail" is not very useful
> > information.  What exactly failed?
> 
> Chris,
> 
> Sorry, I thought this was an understood issue.  I have put the error output 
> I got below.  Basically, when I got to line 509 of data.py the variables had 
> the following values:
> 
> vars = set(['__functions_', '_', '__functions__'])
> 
> var = '__functions__'
> 
> overrides = ['pn-angstrom', 'fail-fast', 'build-linux', 'arm', 'INVALID', 'angstrom-2008.1', '', 'am37x-evm', 'local']
>  
> o = ''
> 
> OVERRIDES = 'pn-angstrom:fail-fast:build-linux:arm:INVALID:angstrom-2008.1::am37x-evm:local'
> 
> The current override being evaluated was the '' one.
> 
> The line being evaluated in my overlay was USERDISTRO := "${DISTRO}" in my 
> copy of angstrom.inc

Chris,

FYI, the below "RuntimeError: Set changed size during iteration" exception 
happens in bitbake 1.8.18 but not the 1.10/mainline.

-- 
Denys

> The output from my build was:
> 
> a0271661 at sdit-build01:~/projects/arago-multi-build$ bitbake helloworldTraceback (most recent call last):
>   File "/home/a0271661/projects/arago-multi-build/arago-bitbake/bin/bitbake", line 143, in <module>
>     main()
>   File "/home/a0271661/projects/arago-multi-build/arago-bitbake/bin/bitbake", line 123, in main
>     cooker.parseConfiguration()
>   File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/cooker.py", line 68, in parseConfiguration
>     self.parseConfigurationFile( os.path.join( "conf", "bitbake.conf" ) )
>   File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/cooker.py", line 390, in parseConfigurationFile
>     self.configuration.data = bb.parse.handle( afile, self.configuration.data )
>   File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/__init__.py", line 75, in handle
>     return h['handle'](fn, data, include)
>   File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/parse_py/ConfHandler.py", line 167, in handle
>     feeder(lineno, s, fn, data)
>   File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/parse_py/ConfHandler.py", line 215, in feeder
>     include(fn, s, data, False)
>   File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/parse_py/ConfHandler.py", line 114, in include
>     ret = handle(fn, data, True)
>   File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/__init__.py", line 75, in handle
>     return h['handle'](fn, data, include)
>   File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/parse_py/ConfHandler.py", line 167, in handle
>     feeder(lineno, s, fn, data)
>   File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/parse_py/ConfHandler.py", line 221, in feeder
>     include(fn, s, data, "include required")
>   File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/parse_py/ConfHandler.py", line 114, in include
>     ret = handle(fn, data, True)
>   File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/__init__.py", line 75, in handle
>     return h['handle'](fn, data, include)
>   File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/parse_py/BBHandler.py", line 175, in handle
>     feeder(lineno, s, fn, base_name, d)
>   File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/parse_py/BBHandler.py", line 381, in feeder
>     return ConfHandler.feeder(lineno, s, fn, d)
>   File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/parse/parse_py/ConfHandler.py", line 192, in feeder
>     bb.data.update_data(e)
>   File "/home/a0271661/projects/arago-multi-build/arago-bitbake/lib/bb/data.py", line 509, in update_data
>     for var in vars:
> RuntimeError: Set changed size during iteration