[oe] [PATCH] base.bbclass: fix soc-family test

Chris Larson clarson at kergoth.com
Fri Sep 10 18:55:13 UTC 2010


On Fri, Sep 10, 2010 at 11:50 AM, Denys Dmytriyenko <denis at denix.org> wrote:

> >> I'd agree with this quite strongly.  I'm generally pretty careful to let
> >> others review the changes from my coworkers, to avoid any bias.
>
> Not to point any fingers, but mishaps happen and numerous reverts would be
> a
> living proof of that in the repository... :) Nobody's perfect.


Mishaps have nothing to do with this, nor does being perfect, or reverts.
 You're missing the point entirely here.  The point is, if the only people
who acked a patch are from the same company as the person who wrote it, they
can't be considered to have been entirely unbiased in their review of it.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics



More information about the Openembedded-devel mailing list