[oe] `PR = "r0"`: Add or not to add?

Anders Darander anders at chargestorm.se
Wed Aug 31 11:55:48 UTC 2011


* Koen Kooi <koen at dominion.thruhere.net> [110831 12:24]:
> Op 31-08-11 12:06, Paul Menzel schreef:
> > Am Mittwoch, den 31.08.2011, 09:15 +0200 schrieb Koen Kooi:
> >> Op 31-08-11 01:06, Andreas Müller schreef:
> >>> * build & partially run tested on overo
> >>> 
> >>> Signed-off-by: Andreas Müller <schnitzeltony at gmx.de> --- .../thunar-volman/thunar-volman_0.6.0.bb           |   12 ++++++++++++ 1 files changed, 12 insertions(+), 0 deletions(-) create mode 100644 meta-xfce/recipes-xfce/thunar-volman/thunar-volman_0.6.0.bb
> >>> 
> >>> diff --git a/meta-xfce/recipes-xfce/thunar-volman/thunar-volman_0.6.0.bb b/meta-xfce/recipes-xfce/thunar-volman/thunar-volman_0.6.0.bb new file mode 100644 index 0000000..ad11d84 --- /dev/null +++ b/meta-xfce/recipes-xfce/thunar-volman/thunar-volman_0.6.0.bb @@ -0,0 +1,12 @@ +DESCRIPTION = 
> >>> "Automatic management of removable drives and media for thunar" +SECTION = "x11" +LICENSE = "GPLv2" +LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f" +DEPENDS = "exo gtk+ libxfce4ui libxfce4util xfconf libnotify" + +PR = "r0"
> > 
> > (Koen, your messages are still not displayed correctly. The line breaks are missing. Could you check your setup? Your messages are the only ones displaying that problem [1].)

> I blame thunderbird auto updates, it suddenly started doing this and I
> couldn't figure out when to change it back. And honestly, I don't
> care.

Well, even though you don't care, it makes reading your replies a lot
harder than necessary. So I guess that most readers of the list would be
happy, if that issue were resolved.

> >> please remove PR in new recipes
> > Actually I would favor to leave them in.
> Well I don't, and atm I decide if it goes in or not.

To sad. 
It's a lot easier to remember to bump the PR, when PR actually is in the
recipe. Thus, including PR=0 will often remove one issue with patches.

> > The manual also advises to do this.
> The manual says a lot of things and was written for .dev, not OE-core
> or meta-oe.

Then the manual needs to be updated for the current usage.

> > To change that policy, I would favor a survey/poll so that not every
> > developers says something different as s/he sees best fit.

> Be sure to include every other variable with a default in that poll in
> order to be consistent.

OTOH, most other variables with defaults do not need to be updated in
most patches...

Cheers,
Anders

-- 
Anders Darander
ChargeStorm AB




More information about the Openembedded-devel mailing list