[oe] [PATCH] Added Europe/Berlin timezone to tzdata pkg
Paul Menzel
paulepanter at users.sourceforge.net
Sun Jan 16 11:47:35 UTC 2011
Dear Lars,
Am Sonntag, den 16.01.2011, 01:45 +0100 schrieb Lars Michelsen:
> I was missing the Europe/Berlin timezone in the tzdata package. So I
> added it to the package.
>
> Additionally increased the PR. Hope this OK for such a change - must
> admit that I am very new to OE.
thank you very much for your patch and welcome to OE.
Could you please resend your patch (`[PATCH v2]`) with the following two
points addressed.
1. The commit summary is standardized and should start with the package
name as documented in the commit policy [1].
tzdata: package `Europe/Berlin` timezone
2. Although it probably does not matter, commit messages are normally
written from a neutral view point(?) and personal comments are added
after a `---` before the diff which starts also with `---`. When
applying your patch, these remarks are left out then.
> Signed-off-by: Lars Michelsen <lm at larsmichelsen.com>
[…]
With these two issues addressed you can add
Acked-by: Paul Menzel <paulepanter at users.sourceforge.net>
to the commit message when resending.
Thanks,
Paul
[1] http://wiki.openembedded.org/index.php/Commit_Policy
[2] http://wiki.openembedded.org/index.php/How_to_submit_a_patch_to_OpenEmbedded#Create_and_Commit_your_patch
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110116/4bea8b4d/attachment-0002.sig>
More information about the Openembedded-devel
mailing list