[oe] [PATCH] Added Europe/Berlin timezone to tzdata pkg

Lars Michelsen lm at larsmichelsen.com
Fri Jan 21 20:30:30 UTC 2011


Hello Paul,

On 16/01/11 12:47, Paul Menzel wrote:
> Dear Lars,
>
>
> Am Sonntag, den 16.01.2011, 01:45 +0100 schrieb Lars Michelsen:
>> I was missing the Europe/Berlin timezone in the tzdata package. So I
>> added it to the package.
>>
>> Additionally increased the PR. Hope this OK for such a change - must
>> admit that I am very new to OE.
>
> thank you very much for your patch and welcome to OE.
>
> Could you please resend your patch (`[PATCH v2]`) with the following two
> points addressed.
>
> 1. The commit summary is standardized and should start with the package
> name as documented in the commit policy [1].
>
> 	tzdata: package `Europe/Berlin` timezone
>
> 2. Although it probably does not matter, commit messages are normally
> written from a neutral view point(?) and personal comments are added
> after a `---` before the diff which starts also with `---`. When
> applying your patch, these remarks are left out then.

Thanks for the information. I'll do so on my next postings.

But after the post of Koen I am unsure if I should resubmit this patch. 
My intend was to fix my time, setting the TZ to Europe/Paris fixes this 
and is absolutely ok for me. Other thoughts?

Regards,
Lars




More information about the Openembedded-devel mailing list