[oe] [PATCH] python-caldav: New reciep - CalDAV rfc4791 client

[Lars Michelsen]

Hello Paul,

thanks for your review.

On 22/01/11 16:59, Paul Menzel wrote:
> Am Samstag, den 22.01.2011, 16:39 +0100 schrieb Lars Michelsen:
>> This patch adds a new reciep for the python caldav client library module.
>
> s/reciep/recipe/ (also in commit summary)
>
> It is not policy, but I like also to have a note in the commit message,
> what distribution and architecture this recipe was build tested with.
> And if it was tested.

Ok, will add those notes in the next patches.

> I did not know of `${SRCNAME}` before. I think `${PN}` is more common
> (since it is shorter?). Now I see that you defined it in the beginning.
> You can use `${PN}`.

I just copied most parts from other python-* recipes. The most of them 
seem to use SRCNAME.

PN containes the whole package name, right? Means 'python-caldav' in 
this case while SRCNAME only contains the module name 'caldav'.

>
>> +inherit setuptools
>> +
>> +SRC_URI[md5sum] = "e5eace7a3b6b7f511a1929a539e6a15d"
>> +SRC_URI[sha256sum] = "4a3b1855000feb8023ab05f8c9e0cfa1648a9abab9ca65ad3e933c22bab61310"
>
> I think these are put right below the first occurrence of `SRC_URI`. But
> the style guide [1] does not mention it explicitly.

Same here. Seam a lot of python-* packages have it at the end of the 
file. While creating/editing such a file it is more intuitive to have 
these definitions right below SRC_URI. So I aggree with you and will 
move these lines.

I just posted a 2nd version of the patch.

Thanks & Regards,
Lars