[oe] [PATCH] x264_r2245: fix DEPENDS for x86

[Paul Menzel]

Am Samstag, den 07.05.2011, 17:59 -0700 schrieb Khem Raj:
> On (04/05/11 11:56), Bob Foerster wrote:

You can be more specific in the commit summary.

	do not override `DEPENDS` for x86

> > The recipe intended to add "yasm-native" to the dependencies on x86,

Use present tense. s/intended/intends/

> > but it set DEPENDS_x86 = "yasm-native" which obliterated the base

s/set/sets/

> > dependencies. On a fresh build, this package was failing since it
> > was trying to build before the compiler was ready.
> > 
> > Depends is now set with DEPENDS_append_x86, which leaves the base
> > dependencies intact.
> > 
> > Signed-off-by: Bob Foerster <robert at erafx.com>
> > ---
> >  recipes/vlc/x264_r2245.bb |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/recipes/vlc/x264_r2245.bb b/recipes/vlc/x264_r2245.bb
> > index 0cffea3..8c2b5b4 100644
> > --- a/recipes/vlc/x264_r2245.bb
> > +++ b/recipes/vlc/x264_r2245.bb
> > @@ -23,7 +23,7 @@ X264_ECFLAGS_mipsel = "-fPIC"
> >  X264_DISABLE_ASM = "--disable-asm"
> >  # use assembler written functions for those archs supporting this
> >  X264_DISABLE_ASM_x86 = ""
> > -DEPENDS_x86 = "yasm-native"
> > +DEPENDS_append_x86 = "yasm-native"
>                          ^
> you need a space 

You should also be able to use +=, should not you?

> Otherwise looks ok
> >  
> >  EXTRA_OECONF = '--enable-shared ${X264_DISABLE_ASM} --extra-cflags="${X264_ECFLAGS}"'


Thanks,

Paul
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110508/ee8808c5/attachment-0002.sig>