[oe] [PATCH] x264_r2245: fix DEPENDS for x86
Phil Blundell
philb at gnu.org
Sun May 8 09:02:36 UTC 2011
On Sun, 2011-05-08 at 08:56 +0200, Paul Menzel wrote:
> Am Samstag, den 07.05.2011, 17:59 -0700 schrieb Khem Raj:
> > On (04/05/11 11:56), Bob Foerster wrote:
>
> You can be more specific in the commit summary.
>
> do not override `DEPENDS` for x86
>
> > > The recipe intended to add "yasm-native" to the dependencies on x86,
>
> Use present tense. s/intended/intends/
If this is talking about the former, erroneous behaviour (which is
corrected by this patch) then the past tense is correct.
> > > -DEPENDS_x86 = "yasm-native"
> > > +DEPENDS_append_x86 = "yasm-native"
> > ^
> > you need a space
>
> You should also be able to use +=, should not you?
No, += doesn't work with overrides. "DEPENDS_x86 +=" would do the same
wrong thing as the original "DEPENDS_x86".
p.
More information about the Openembedded-devel
mailing list