[oe] [PATCH] libsdl-pango: new recipe for version 0.1.2

[Paul Menzel]

Dear Christian,


Am Dienstag, den 17.05.2011, 22:42 +0200 schrieb Christian Charreyre:
> This patches creates a new recipe for libsdl-pango.

»This patch …« is most of the time redundant in a commit message. You
could read [1].

> It uses debian patches, unless rebootstrap.patch which is very big and doesn't 
> seem necessary for the recipe.

Please add the link/URL of the Debian patches.

What machine and distribution (custom right) did you use?

> Signed-off-by: Christian Charreyre <christian.charreyre at cioinfoindus.fr>
> ---
>  .../libsdl-pango-0.1.2/am_maintainer_mode.patch    |   10 ++
>  .../libsdl/libsdl-pango-0.1.2/api_additions.patch  |  128 +++++++++++++++++++
>  .../libsdl/libsdl-pango-0.1.2/blit_overflow.patch  |   32 +++++
>  .../libsdl/libsdl-pango-0.1.2/fillrect_crash.patch |   15 +++
>  .../libsdl-pango-0.1.2/matrix_declarations.patch   |  131 ++++++++++++++++++++
>  recipes/libsdl/libsdl-pango-0.1.2/sans-serif.patch |   13 ++
>  recipes/libsdl/libsdl-pango_0.1.2.bb               |   27 ++++
>  7 files changed, 356 insertions(+), 0 deletions(-)
>  create mode 100644 recipes/libsdl/libsdl-pango-0.1.2/am_maintainer_mode.patch
>  create mode 100644 recipes/libsdl/libsdl-pango-0.1.2/api_additions.patch
>  create mode 100644 recipes/libsdl/libsdl-pango-0.1.2/blit_overflow.patch
>  create mode 100644 recipes/libsdl/libsdl-pango-0.1.2/fillrect_crash.patch
>  create mode 100644 recipes/libsdl/libsdl-pango-0.1.2/matrix_declarations.patch
>  create mode 100644 recipes/libsdl/libsdl-pango-0.1.2/sans-serif.patch
>  create mode 100644 recipes/libsdl/libsdl-pango_0.1.2.bb

[…]

> --- /dev/null
> +++ b/recipes/libsdl/libsdl-pango_0.1.2.bb
> @@ -0,0 +1,27 @@
> +DESCRIPTION = "Simple DirectMedia Layer Pango library."
> +SECTION = "libs/network"
> +PRIORITY = "optional"
> +DEPENDS = "virtual/libsdl pango"
> +LICENSE = "LGPL"

Please sort those according to the style guide [2]. Setting `HOMEPAGE`
would be nice too.

> +
> +SRC_URI = "http://freefr.dl.sourceforge.net/project/sdlpango/SDL_Pango/${PV}/SDL_Pango-${PV}.tar.gz \

You should use `SOURCEFORGE_MIRROR`.

	git grep SOURCEFORGE_MIRROR

> +	file://am_maintainer_mode.patch \
> +	file://api_additions.patch \
> +	file://matrix_declarations.patch \
> +	file://sans-serif.patch \
> +	file://fillrect_crash.patch \
> +	file://blit_overflow.patch \
> +"
> +
> +SRC_URI[md5sum] = "85bbf9bb7b1cee0538154dadd045418c"
> +SRC_URI[sha256sum] = "7f75d3b97acf707c696ea126424906204ebfa07660162de925173cdd0257eba4"
> +
> +S = "${WORKDIR}/SDL_Pango-${PV}"
> +
> +inherit autotools
> +
> +EXTRA_OECONF += "SDL_CONFIG=${STAGING_BINDIR_CROSS}/sdl-config"
> +
> +do_stage() {
> +	autotools_stage_all
> +}

As Henning wrote already, `do_stage()` should not be used anymore [3].
Probably the documentation you used is outdated.

Unfortunately trying to build this recipe task patch fails with the
following error message using `angstrom-2010.x` for `MACHINE =
"beagleboard"`.

	NOTE: package libsdl-pango-0.1.2-r0: task do_patch: Started
	ERROR: Execution of 'quilt --quiltrc=/oe/build-angstrom-next/angstrom-dev/sysroots/i686-linux/usr/bin/quiltrc push' failed with exit code 1:
	Applying patch am_maintainer_mode.patch
	patching file configure.in
	Hunk #1 FAILED at 1.
	1 out of 1 hunk FAILED -- rejects in file configure.in
	Patch am_maintainer_mode.patch does not apply (enforce with -f)

	NOTE: package libsdl-pango-0.1.2-r0: task patch_do_patch: Failed


Thanks,

Paul


[1] http://lists.linuxtogo.org/pipermail/openembedded-devel/2011-May/032692.html
[2] http://openembedded.org/index.php/Styleguide
[3] http://openembedded.org/index.php/Legacy_staging
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110517/e43bcc6d/attachment-0002.sig>