[oe] [PATCH] libsdl-pango: new recipe for version 0.1.2

[Christian Charreyre]

Dear Paul,

I'll try to correct what is wrong, and resubmit the patch.

Le 17/05/2011 23:43, Paul Menzel a écrit :
> Dear Christian,
>
>
> Am Dienstag, den 17.05.2011, 22:42 +0200 schrieb Christian Charreyre:
>> This patches creates a new recipe for libsdl-pango.
> »This patch …« is most of the time redundant in a commit message. You
> could read [1].
OK, thanks for the reference.
>> It uses debian patches, unless rebootstrap.patch which is very big and doesn't
>> seem necessary for the recipe.
> Please add the link/URL of the Debian patches.
OK
> What machine and distribution (custom right) did you use?
MACHINE = beagleboard, DISTRO=angstrom-2008.1
I'll put it in the comment next time.

[...]

>> --- /dev/null
>> +++ b/recipes/libsdl/libsdl-pango_0.1.2.bb
>> @@ -0,0 +1,27 @@
>> +DESCRIPTION = "Simple DirectMedia Layer Pango library."
>> +SECTION = "libs/network"
>> +PRIORITY = "optional"
>> +DEPENDS = "virtual/libsdl pango"
>> +LICENSE = "LGPL"
> Please sort those according to the style guide [2]. Setting `HOMEPAGE`
> would be nice too.
OK, sorted
>> +
>> +SRC_URI = "http://freefr.dl.sourceforge.net/project/sdlpango/SDL_Pango/${PV}/SDL_Pango-${PV}.tar.gz \
> You should use `SOURCEFORGE_MIRROR`.
>
> 	git grep SOURCEFORGE_MIRROR
OK, I'll use as soon as possible macros.
>> +	file://am_maintainer_mode.patch \
>> +	file://api_additions.patch \
>> +	file://matrix_declarations.patch \
>> +	file://sans-serif.patch \
>> +	file://fillrect_crash.patch \
>> +	file://blit_overflow.patch \
>> +"
>> +
>> +SRC_URI[md5sum] = "85bbf9bb7b1cee0538154dadd045418c"
>> +SRC_URI[sha256sum] = "7f75d3b97acf707c696ea126424906204ebfa07660162de925173cdd0257eba4"
>> +
>> +S = "${WORKDIR}/SDL_Pango-${PV}"
>> +
>> +inherit autotools
>> +
>> +EXTRA_OECONF += "SDL_CONFIG=${STAGING_BINDIR_CROSS}/sdl-config"
>> +
>> +do_stage() {
>> +	autotools_stage_all
>> +}
> As Henning wrote already, `do_stage()` should not be used anymore [3].
> Probably the documentation you used is outdated.
This was due to a copy of an old recipe, it's not necessary, so I 
suppress it.
> Unfortunately trying to build this recipe task patch fails with the
> following error message using `angstrom-2010.x` for `MACHINE =
> "beagleboard"`.
>
> 	NOTE: package libsdl-pango-0.1.2-r0: task do_patch: Started
> 	ERROR: Execution of 'quilt --quiltrc=/oe/build-angstrom-next/angstrom-dev/sysroots/i686-linux/usr/bin/quiltrc push' failed with exit code 1:
> 	Applying patch am_maintainer_mode.patch
> 	patching file configure.in
> 	Hunk #1 FAILED at 1.
> 	1 out of 1 hunk FAILED -- rejects in file configure.in
> 	Patch am_maintainer_mode.patch does not apply (enforce with -f)
>
> 	NOTE: package libsdl-pango-0.1.2-r0: task patch_do_patch: Failed
Here is the trouble, I have rebuilt it with bitbake 1.8.18 and bitbake 
1.10.2 without error.
Could you have a more precise look on what is wrong with the patch on 
your conf., because it is quite simple, and I don't understand
why do_patch gives you an error. Perhaps I don't use quilt in do_patch 
(don't know where to look to see what do_patch really do).
Thanks for your answer.

>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: christian_charreyre.vcf
Type: text/x-vcard
Size: 277 bytes
Desc: not available
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20110518/8870ffe8/attachment-0002.vcf>