[oe] [oe-commits] Otavio Salvador : libav: Change the PACKAGES_DYNAMIC expression to be more restrict

[Otavio Salvador]

On Thu, Oct 11, 2012 at 6:01 AM, Martin Jansa <martin.jansa at gmail.com> wrote:
> On Wed, Oct 10, 2012 at 10:42:52AM +0000, git at git.openembedded.org wrote:
>> Module: meta-openembedded.git
>> Branch: master
>> Commit: 97350f52280ea9b2f3d7b36ef248be5ba3e7c696
>> URL:    http://git.openembedded.org/?p=meta-openembedded.git&a=commit;h=97350f52280ea9b2f3d7b36ef248be5ba3e7c696
>>
>> Author: Otavio Salvador <otavio at ossystems.com.br>
>> Date:   Sat Oct  6 20:18:30 2012 +0000
>>
>> libav: Change the PACKAGES_DYNAMIC expression to be more restrict
>>
>> Using 'lib*' we end having problem with every other package that
>> generate libraries dynamically thus we changed it to match the library
>> prefixes.
>>
>> Signed-off-by: Otavio Salvador <otavio at ossystems.com.br>
>> Signed-off-by: Koen Kooi <koen at dominion.thruhere.net>
>>
>> ---
>>
>>  meta-oe/recipes-multimedia/libav/libav.inc |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/meta-oe/recipes-multimedia/libav/libav.inc b/meta-oe/recipes-multimedia/libav/libav.inc
>> index aa170c5..4a1716f 100644
>> --- a/meta-oe/recipes-multimedia/libav/libav.inc
>> +++ b/meta-oe/recipes-multimedia/libav/libav.inc
>> @@ -119,4 +119,4 @@ python populate_packages_prepend() {
>>                        allow_links=True)
>>  }
>>
>> -PACKAGES_DYNAMIC = "lib*"
>> +PACKAGES_DYNAMIC = "lib(av(codec|device|filter|format|util)|postproc)*"
>
> Unfortunatelly this does not work, this regexp matches everything starting with 'lib',
> so it's only a bit more strict then old version which matched everything starting with 'li' :).
>
> Please change it to:
> PACKAGES_DYNAMIC = "^lib(av(codec|device|filter|format|util)|postproc)"
> or
> PACKAGES_DYNAMIC = "^lib(av(codec|device|filter|format|util)|postproc).*"
>
> ^ isn't used in any PACKAGES_DYNAMIC in oe-core, but it could make matching faster
> * is used wrong in all PACKAGES_DYNAMIC in oe-core (as in glob, but not regexp), so all those last '-' are optional

PACKAGES_DYNAMIC =
"^lib(av(codec|device|filter|format|util)|postproc).*" is the right
one.

Koen, I am traveling but people amend my patch commit it please ... or
I send a new revision next week.

-- 
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br