[oe] gst-ffmpeg configure-fix patch and yasm

dv dv at pseudoterminal.org
Sat Mar 30 20:30:51 UTC 2013


On 03/30/13 17:40, Otavio Salvador wrote:
> On Sat, Mar 30, 2013 at 12:00 PM, dv <dv at pseudoterminal.org> wrote:
>> Hello,
>>
>> I noticed this part of the configure-fix.patch file for gst-ffmpeg 0.10.13:
>>
>> +  if test "x$disable_yasm" != "xyes"; then
>> +    embffmpeg_configure_args="$embffmpeg_configure_args --disable-yasm"
>> +  fi
>>
>> Shouldn't the test be:  if test "x$disable_yasm" = "xyes"  ?
>> To me, it seems as if this code adds --disable-yasm if disable_yasm is not
>> set to "yes", which is the complete opposite of the intended behavior.
>>
>> Or am I missing some detail about shell script code here?
> I think you are right here. Maybe you could provide a fix for it?
> --
> Otavio Salvador                             O.S. Systems
> E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
> Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br
>
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-devel

No problem. Patch for the patch attached :)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-gst-ffmpeg-configure-fix-patch-used-wrong-test.patch
Type: text/x-patch
Size: 1036 bytes
Desc: not available
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20130330/67b05b1f/attachment-0002.bin>


More information about the Openembedded-devel mailing list