[oe] gst-ffmpeg configure-fix patch and yasm

[Otavio Salvador]

Hello,

On Sat, Mar 30, 2013 at 5:30 PM, dv <dv at pseudoterminal.org> wrote:
> On 03/30/13 17:40, Otavio Salvador wrote:
>>
>> On Sat, Mar 30, 2013 at 12:00 PM, dv <dv at pseudoterminal.org> wrote:
>>>
>>> Hello,
>>>
>>> I noticed this part of the configure-fix.patch file for gst-ffmpeg
>>> 0.10.13:
>>>
>>> +  if test "x$disable_yasm" != "xyes"; then
>>> +    embffmpeg_configure_args="$embffmpeg_configure_args --disable-yasm"
>>> +  fi
>>>
>>> Shouldn't the test be:  if test "x$disable_yasm" = "xyes"  ?
>>> To me, it seems as if this code adds --disable-yasm if disable_yasm is
>>> not
>>> set to "yes", which is the complete opposite of the intended behavior.
>>>
>>> Or am I missing some detail about shell script code here?
>>
>> I think you are right here. Maybe you could provide a fix for it?
...
> No problem. Patch for the patch attached :)

Please Martin,

Can you review the patch in this thread?

Regards,

--
Otavio Salvador                             O.S. Systems
E-mail: otavio at ossystems.com.br  http://www.ossystems.com.br
Mobile: +55 53 9981-7854              http://projetos.ossystems.com.br