[oe] [meta-oe][PATCH v7 6/7] opencv: Fix build on x86 platform

[Khem Raj]

> On Apr 1, 2016, at 2:57 PM, Ricardo Ribalda Delgado <ricardo.ribalda at gmail.com> wrote:
> 
> Hi Andre
> 
> += does not add the leading space?
> 
> http://www.yoctoproject.org/docs/2.0/bitbake-user-manual/bitbake-user-manual.html#appending-and-prepending-override-style-syntax
> 
> I thought += was preferred.

its not a designed behavior but a byproduct.

> 
> I am confused. What shall I resend += " foo" or = " foo”

append/prepend without any override style syntax is much cleaner to understand

> ?
> 

> Regards
> 
> On Fri, Apr 1, 2016 at 11:46 PM, Andre McCurdy <armccurdy at gmail.com> wrote:
>> On Fri, Apr 1, 2016 at 2:36 PM, Ricardo Ribalda Delgado
>> <ricardo.ribalda at gmail.com> wrote:
>>> OpenCV wrongly assumes that the X86 variable would be set on Intel 32
>>> bit architectures.
>>> 
>>> This patch adds the missing definition on those cases.
>>> 
>>> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda at gmail.com>
>>> ---
>>> meta-oe/recipes-support/opencv/opencv_3.1.bb | 1 +
>>> 1 file changed, 1 insertion(+)
>>> 
>>> diff --git a/meta-oe/recipes-support/opencv/opencv_3.1.bb b/meta-oe/recipes-support/opencv/opencv_3.1.bb
>>> index 63955a862d4a..b89fbbb214f6 100644
>>> --- a/meta-oe/recipes-support/opencv/opencv_3.1.bb
>>> +++ b/meta-oe/recipes-support/opencv/opencv_3.1.bb
>>> @@ -45,6 +45,7 @@ EXTRA_OECMAKE = "-DPYTHON2_NUMPY_INCLUDE_DIRS:PATH=${STAGING_LIBDIR}/${PYTHON_DI
>>>                  ${@base_conditional("libdir", "/usr/lib64", "-DLIB_SUFFIX=64", "", d)} \
>>>                  ${@base_conditional("libdir", "/usr/lib32", "-DLIB_SUFFIX=32", "", d)} \
>>> "
>>> +EXTRA_OECMAKE_append_x86 = "-DX86=ON"
>> 
>> That should be:
>> 
>> EXTRA_OECMAKE_append_x86 = " -DX86=ON"
>> 
>> Note the leading space. See:
>> 
>>  http://www.yoctoproject.org/docs/2.0/bitbake-user-manual/bitbake-user-manual.html#appending-and-prepending-override-style-syntax
>> 
>>> 
>>> PACKAGECONFIG ??= "eigen jpeg png tiff v4l libv4l gstreamer samples tbb \
>>>                    ${@bb.utils.contains("DISTRO_FEATURES", "x11", "gtk", "", d)} \
>>> --
>>> 2.8.0.rc3
>>> 
> 
> 
> 
> --
> Ricardo Ribalda
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel at lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 204 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://lists.openembedded.org/pipermail/openembedded-devel/attachments/20160401/6857d0c9/attachment-0002.sig>